Return status code from openfec codec

[gavv]

Summary

fec::IBlockEncoder and fec::IBlockDecoder are interfaces for codec-specific encoding and decoding of FEC packets used for packet loss recovery. See documentation.

They both have begin_block() method which can report error by returning status::StatusCode.

We need to update their other methods so that they return status code as well (currently they are void): end_block(), set_buffer(), fill_buffers(), repair_buffer().

Implementation

• Update IBlockEncoder and IBlockDecoder interfaces and two implementations:
  • fec::OpenfecEncoder
  • fec::OpenfecDecoder
• In OpenfecEncoder and OpenfecDecoder, find invocations of of_xxx() functions, check for errors, and return status code in case of error (currently errors are either unhandled or cause panic)
• Update fec::BlockWriter and fec::BlockReader, which use IBlockEncoder and IBlockDecoder interfaces. When encoder or decoder return error code, writer and reader should forward it to upper level.

[spran180]

Hey @gavv, I am interested in solving this issue.

[gavv]

@spran180 You're welcome, thanks!

[spran180]

Hey @gavv, do we need to update all functions that are void and uses roc_panic to status::code in OpenfecEncoder and OpenfecDecoder, such as update_() or decode_(), or do we just need to update the specified function?

[gavv]

Hey @gavv, do we need to update all functions that are void and uses roc_panic to status::code in OpenfecEncoder and OpenfecDecoder, such as update_() or decode_(), or do we just need to update the specified function?

The first. Ideally, we need to handle and forward errors from every of_xxx() function.