Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate check-dexer.gradle from groovy to kotlin i.e. to check-dexer.gradle.kts #1456

Open
robstoll opened this issue Jun 4, 2023 · 4 comments
Labels

Comments

@robstoll
Copy link
Owner

robstoll commented Jun 4, 2023

Code related feature

We check that Atrium works with android sdk api level 26 during CI by running d8 (dexer) --> see .github/workflows/build-ubuntu.yml => step download Android SDK's android.jar (or use cached file)

The configuration for this is done in rootProjectFolder/gradle/scripts/check-dexer.gradle

Note that we apply this script only if CI=true (see rootProjectFolder/build.gradle.kts). I recommend you comment out the if (~Line 560) during development so that intellij correctly highlights the syntax etc.

In order that you can run ./gradlew checkDexer you need to define ATRIUM_ANDROID_JAR which needs to point to the android.jar of the SDK. See .github/build-windows.yml to see how you can download the sdk.

Note that we are not compatible with API level 25. So it is best to make a negative test, i.e. check if ./gradlew checkDexer still fails if you point it to the android-25.jar

Your first contribution?

  • Write a comment I'll work on this if you would like to take this issue over.
    This way we get the chance to revise the description in case things have changed in the meantime, we might give you additional hints and we can assign the task to you, so that others do not start as well.
  • See Your first code contribution for guidelines.
  • Do not hesitate to ask questions here or to contact us via Atrium's slack channel if you need help
    (Invite yourself in case you do not have an account yet).
@RealOkabe
Copy link

I'll work on this.

@RealOkabe
Copy link

Sorry I went on a vacation and I wasn't able to work on this. I am back now. Starting work on this again.

@RealOkabe
Copy link

I give up. Just setting up the environment is a pain and no one wants to help.

@robstoll
Copy link
Owner Author

@RealOkabe I can still try to help. Last thing you mentioned, when we tried to tackle your Windows issues was that you will see if it works out with a linux distro. As mentioned when you sought help via slack, you can ignore the failing PathExpectation tests and focus on rewriting groovy to kotlin. We will see in CI if you broke something by accident. In any case, I am here to help in case you still want to give it try. If not, then please un-assign yourself from the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants