Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent namespace naming #14

Open
kamileczek opened this issue Aug 12, 2015 · 1 comment
Open

Inconsistent namespace naming #14

kamileczek opened this issue Aug 12, 2015 · 1 comment

Comments

@kamileczek
Copy link

Hello,

this is not an issue which breaks code or make message invalid but leads to inconsistent namespace prefixing. Everywhere in code namespace http://www.w3.org/2000/09/xmldsig has prefix "ds" (from XMLSecurityDSig class) but in WSSESoap::addEncryptedKey() this namspace is introduced with prefix "dsig".

Line 318:

$keyInfo = $objDoc->createElementNS('http://www.w3.org/2000/09/xmldsig#', 'dsig:KeyInfo');

Thank you!

@garex
Copy link
Contributor

garex commented Jul 18, 2016

I think it's better to have same Ns everywhere

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants