Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In a YCM superbuild, CMAKE_GENERATOR_PLATFORM is not propagated correctly to subproject #177

Closed
traversaro opened this issue Nov 1, 2018 · 5 comments
Closed

In a YCM superbuild, CMAKE_GENERATOR_PLATFORM is not propagated correctly to subproject #177

traversaro opened this issue Nov 1, 2018 · 5 comments

Comments

@traversaro
Copy link
Member

If I configure a superbuild as:

cmake -G "Visual Studio 15 2017" -A x64 ...

The subprojects will use the Win32 (i.e. x86 32-bit) platform generator, instead of the x64 (i.e. amd64 64-bit).

Everything works fine (the subprojects build for 64-bit) if I use the old-style generators names:

cmake -G "Visual Studio 15 2017 Win64" ..

I guess that his related to the fact that YCM uses an outdated ExternalProject fork, for which for example this commit is missing: :https://gitlab.kitware.com/cmake/cmake/commit/6944997bd6aa69fdf88f8e4e154e68d57195b20b .
@weekly-digest weekly-digest bot mentioned this issue Nov 4, 2018
Closed
@traversaro
Copy link
Member Author

Related to #50 .

@traversaro
Copy link
Member Author

traversaro commented Dec 7, 2018 •
edited by unfurl-links bot
Loading

This will probably be an hard requirement to support Visual Studio 2019 : https://gitlab.kitware.com/cmake/cmake/merge_requests/2711#note_493161 .

GitLab
[CMake](https://cmake.org), the cross-platform, open-source build system.

traversaro referenced this issue in robotology/blockfactory Dec 13, 2018
@diegoferigo
Use script.sh in Travis CI also for Windows
722b7b7
@drdanz drdanz pinned this issue Dec 14, 2018
@traversaro traversaro mentioned this issue Jan 3, 2019
Closed
@drdanz
Copy link
Member

drdanz commented Mar 14, 2019

@traversaro Is this fixed by #188?

@traversaro
Copy link
Member Author

Yes.

@traversaro
Copy link
Member Author

@Nicogene you had a related problem, right?

@drdanz drdanz unpinned this issue Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@drdanz @traversaro