You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think that the method: yarp::os::BufferedPort::setStrict(bool strict=true)
can generate some kind of confusion with methods: yarp::os::BufferedPort::writeStrict () yarp::os::BufferedPort::write (bool forceStrict=false)
While the behavior is well explained in yarp documentation, an unexperienced user can still think that setStrict() affects the BufferedPort when writing data.
Since setStrict() affects only the BufferedPort in receiver mode, I propose to deprecate it, in favor of a method with a clear name, such as: yarp::os::BufferedPort::setReceivingStrict() (or similar)
This discussion was converted from issue #1970 on December 22, 2020 09:10.
Heading
Bold
Italic
Quote
Code
Link
Numbered list
Unordered list
Task list
Attach files
Mention
Reference
Menu
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
I think that the method:
yarp::os::BufferedPort::setStrict(bool strict=true)
can generate some kind of confusion with methods:
yarp::os::BufferedPort::writeStrict ()
yarp::os::BufferedPort::write (bool forceStrict=false)
While the behavior is well explained in yarp documentation, an unexperienced user can still think that
setStrict()
affects the BufferedPort when writing data.Since
setStrict()
affects only the BufferedPort in receiver mode, I propose to deprecate it, in favor of a method with a clear name, such as:yarp::os::BufferedPort::setReceivingStrict()
(or similar)Beta Was this translation helpful? Give feedback.
All reactions