-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for D455 camera #11
Comments
I've checked with realsense developers IntelRealSense/librealsense#8810 (comment) and D455 camera sends distorted images, so I think we have to implement inverse brown conrady distortion to use this camera. The distortion is not so high so it can also be used undistorted, but the correct way to add it is to implement inverse brown conrady distortion. |
Thanks @ste93 for looking into that. From this comment, it seems that indeed there is a bug in how the D455 camera is handled in https://github.com/IntelRealSense/realsense-ros (see also IntelRealSense/realsense-ros#1580 ). |
yes, I think that ros has a bug inside (that I think they're trying to solve) since it returns the wrong distortion model. For the realsense driver I think that there are also there some bugs (as can be seen here IntelRealSense/librealsense#7335) the last commit is 2 days ago and it referenced D455 and inverse brown conrady, so I think this is still a work in progress. |
I think this can be useful for the addition of inverse brown conrady IntelRealSense/librealsense@90fa2ed |
just for tracking, new librealsense has been released yesterday and it seems that they have added undistortion also with inverse brown conrady, but camera firmware must be updated. We will check it when R1SN003 will return from Turin. |
until now the d455 camera is not working with this device, the support must be added but checking which distortion is returning (maybe adding the INVERSE_BROWN_CONRADY distortion) and must be checked if is useful to have those parameters, together with the check if the image returned is distorted or not
The text was updated successfully, but these errors were encountered: