-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the usage of yarp::dev::IAnalogSensors
#929
Comments
I tried to write down the current situation with some possible action points for what I know, @marcoaccame @traversaro @pattacini please feel free to contribute to this table |
yarp::dev::IAnalogSensors
yarp::dev::IAnalogSensors
– Stint 1
fyi @valegagge , as apparently she was the original author of |
Hi guys, I also looked around in the fw. the code that can publish such values still exists, but I didn't understand if they are broadcasted toward YRI.(I guess no) Said that, I suppose that now there are very occasions where we need to check the raw value of the spichainof3 encoder. they are only on R1 robot. In my opinion, we can remove the device, but we need to take into account that maybe we need to develop it. (it is a slim chance.) |
/remind 6th may plan for action points |
⏰ Reminder
|
Action points
|
I converted this to an Epic, you can link your activities to this. cc @pattacini @valegagge @marcoaccame @MSECode @simeonedussoni @mfussi66 |
yarp::dev::IAnalogSensors
– Stint 1yarp::dev::IAnalogSensors
I let things get out of hand and in the PR listed below I removed it also from other devices that had been already ported to the usage of the MultipleAnalogSensorsInterfaces
Looking at the usage of
yarp::dev::IAnalogSensor
interface inicub-main
some devices still use it and they have not been ported to the MAS interfaces:canBusAnalogSensor
canBusInertialMTB
canBusMotionControl
canBusSkin
embObjMulltiEnc
embObjPOS
embObjPSC
embObjSkin
skinWrapper
skinManager
We know that the skin pipeline has to be refactored, maybe some of them can be removed completely as we did for the
embObjAnalogSensor
For the remaining we have to chat with @marcoaccame
Originally posted by @Nicogene in #919 (comment)
The text was updated successfully, but these errors were encountered: