Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong formula for data values #1

Open
wavoigt opened this issue Mar 6, 2021 · 3 comments
Open

wrong formula for data values #1

wavoigt opened this issue Mar 6, 2021 · 3 comments

Comments

@wavoigt
Copy link

wavoigt commented Mar 6, 2021

Hi Robert,
thank you for doing a great job.
I found an issue on calculating the data values in scopedump.vbs:
blockVal = DataBlock(Index + 1) + 256 * DataBlock(Index + 0)
must be blockVal = DataBlock(Index + 1) * 256 + DataBlock(Index + 0)
regards,
Walter

@roberttidey
Copy link
Owner

Thanks for pointing out an error in the vbscript version I had only really used that for help in developing the python to json version.

The problem was actually really rooted in the block arrays used to hold the values starting from 1 not 0.

I have corrected that and the calculation of the values.

@wavoigt
Copy link
Author

wavoigt commented Mar 12, 2021

Hi Robert,
i made a 1013D .wav viewer in Excel:
https://github.com/wavoigt/FNIRSI-1013D-WAV-Viewer-in-Excel-VBA
regards, Walter

@roberttidey
Copy link
Owner

That's very good. Useful for further calculations, print outs etc.

I have added a link in my README. I hope that's OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants