Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add content-disposition filename to all image responses #7

Open
robcast opened this issue Sep 6, 2017 · 1 comment
Open

add content-disposition filename to all image responses #7

robcast opened this issue Sep 6, 2017 · 1 comment
Labels
enhancement low-priority

Comments

@robcast
Copy link
Owner

robcast commented Sep 6, 2017

Currently we only add a filename via content-disposition for mo=rawfile.

IIIF Image API http://iiif.io/api/image/2.0/#a-implementation-notes proposes to always set a file name via content-disposition.
robcast added a commit that referenced this issue Sep 6, 2017
@robcast
implementing #7
036970c 
* sents content-disposition filename for all files sent-as-is
* takes filename for generated images from "download-filename" hint 
(but hint is not yet generated).
@robcast
Copy link
Owner Author

robcast commented Sep 6, 2017

send-file currently uses the server-side file name which is ok.

send-image does not yet get a file name. I think it should be added when scaling the image. Should the file name also include zoom area and size?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement low-priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@robcast