Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stack handler config logic problem #1147

Closed
bug-or-feature opened this issue Apr 19, 2023 · 6 comments
Closed

Stack handler config logic problem #1147

bug-or-feature opened this issue Apr 19, 2023 · 6 comments

Comments

@bug-or-feature
Copy link
Collaborator

There's some kind of config logic error somewhere in the stack handler. This shows up while testing the new logging system, doesn't show under current system. Every second or so a message like this appears in the logs:

2023-04-19 10:55:18 DEBUG config {'type': 'config', 'stage': 'config'} Adding config defaults

Looks like maybe some loop is reading a config value on every iteration, instead of once at the beginning. Maybe suppressed in current system by _check_msg_logged_recently_or_update_hash()

@robcarver17
Copy link
Owner

I'm not seeing this.

@bug-or-feature
Copy link
Collaborator Author

I think it was fixed by PR #1166

@oldlore
Copy link

oldlore commented Sep 1, 2023

I know this is old but I still see this popping up a few times a second in the stack handler echo.

@bug-or-feature
Copy link
Collaborator Author

Yeah, me too. I'm working in this area in my own fork. I'll track it down eventually!

@bug-or-feature
Copy link
Collaborator Author

@oldlore found it finally 😄

@oldlore
Copy link

oldlore commented Nov 3, 2023

Yay! My SSD thanks you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants