Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to Go code colors after vscode upgrade #309

Open
jrefior opened this issue Mar 7, 2024 · 3 comments
Open

Change to Go code colors after vscode upgrade #309

jrefior opened this issue Mar 7, 2024 · 3 comments

Comments

@jrefior
Copy link

jrefior commented Mar 7, 2024

Thanks for the great color scheme! I've been using it for years now.

Something changed in recent versions of vscode for the application of this color scheme to Go code. There used to be a lot of magenta (purple?) text, now I think all the magenta turned light blue.

Screenshot from 2024-03-07 09-18-35

My JavaScript files still have the magenta text.

I have Go language support v0.41.1 (latest). I updated vscode today (to 1.87.0) in hopes that would fix it, but it didn't. I think it's been weeks since I saw the right colors.

I also tried uninstalling and reinstalling Synthwave '84.

I still see the magenta text only in function definitions, in parameter names:

Screenshot from 2024-03-07 09-40-50

@jrefior
Copy link
Author

jrefior commented Mar 12, 2024

Perhaps some useful context I found in a vscode github issue:

https://marketplace.visualstudio.com/items?itemName=golang.Go does not supply its own go grammar
but instead relies on VSCode's builtin go grammar
which changed in 1.86

I wonder if vscode's go grammar change broke a lot of color schemes?

@jrefior
Copy link
Author

jrefior commented Mar 12, 2024

It looks like it did. I found two more related vscode issues:

Go highlighted differently after January 2024 update

1.86+ updates Go grammar to remove most uncolored tokens

@jrefior
Copy link
Author

jrefior commented Mar 23, 2024

I don't know how this can be fixed, or even if it can be fixed.

The thing I'm trying now, to adapt, is to use SynthWave '84 as my default theme, but then in Go projects set a different theme for the workspace.

For those who want to try my setup, follow instructions on StackOverflow for workbench theme settings.

I'm currently trying the Palenight theme for only Go projects (again, SynthWave default). I chose "Palenight (Mild Contrast)".

It's a bit tricky to test out different color schemes, because the colors can (sometimes... is this related to Neon Dreams?) look one way when you install a theme and select it in workbench settings, and then look different when you restart the editor. The post-restart one is what it will look like from then on. So a bit tedious to test out different themes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant