decrypt from file to text not an OpenPGP data provided, yet it works

[shemeshg]

Hi

When I decrypt from file to text I get.

[process_pgp_source() /Volumes/RAM_Disk_4G/pass-simple-qt/gpgfactory/libpgpfactory/rnp/src/librepgp/stream-parse.cpp:2873] not an OpenPGP data provided

this does not exists when decrypt from file to file.
However it does decrypt successfully - so it is kind of a warning I get.

void LibGpgFactoryRnp::decryptFileToString(const std::string &filePath,
                                           std::string &decrypted,
                                           std::vector<std::string> &decryptedSignedBy)
{
    rnp_input_t input = NULL;
    rnp_output_t output = NULL;
    uint8_t *buf = NULL;
    size_t buf_len = 0;
    if (rnp_input_from_path(&input, filePath.c_str()) != RNP_SUCCESS) {
        throw std::runtime_error("failed to create input object\n");
    }

    if (rnp_output_to_memory(&output, 0) != RNP_SUCCESS) {
        throw std::runtime_error("failed to create output object\n");
    }

    if (rnp_decrypt(rnp.ffi, input, output) != RNP_SUCCESS) {
        throw std::runtime_error("LoginReq:");
    }

    /* get the decrypted message from the output structure */
    if (rnp_output_memory_get_buf(output, &buf, &buf_len, false) != RNP_SUCCESS) {
        throw std::runtime_error("rnp_output_memory_get_buf failed\n");
    }

    decrypted = std::string(buf, buf + buf_len);

    rnp_op_verify_t verify = NULL;

    if (rnp_op_verify_create(&verify, rnp.ffi, input, output) != RNP_SUCCESS) {
        throw std::runtime_error("failed to create verification context\n");
    }
    rnp_op_verify_execute(verify);
    
    size_t sigcount = 0;
    if (rnp_op_verify_get_signature_count(verify, &sigcount) != RNP_SUCCESS) {
        throw std::runtime_error("failed to get signature count\n");
    }
    std::cout << "Number of sigcount " << sigcount << "\n";
    for (size_t i = 0; i < sigcount; i++) {
        rnp_op_verify_signature_t sig = NULL;
        //rnp_result_t sigstatus = RNP_SUCCESS;
        rnp_key_handle_t key = NULL;
        char *keyid = NULL;

        if (rnp_op_verify_get_signature_at(verify, i, &sig) != RNP_SUCCESS) {
            throw std::runtime_error("failed to get signature " + std::to_string(i) + "\n");
        }

        if (rnp_op_verify_signature_get_key(sig, &key) != RNP_SUCCESS) {
            throw std::runtime_error("failed to get signature's " + std::to_string(i) + " key\n");
        }

        if (rnp_key_get_keyid(key, &keyid) != RNP_SUCCESS) {
            rnp_key_handle_destroy(key);
            throw std::runtime_error("failed to get key id " + std::to_string(i) + "\n");
        }

        //sigstatus = rnp_op_verify_signature_get_status(sig);
        decryptedSignedBy.push_back(keyid);
        rnp_buffer_destroy(keyid);
        rnp_key_handle_destroy(key);
    }

    rnp_input_destroy(input);
    rnp_output_destroy(output);
}

initialized with

void LibGpgFactoryRnp::initPgpFactory()
{
    if (ctxInitialized) {
        return;
    }
    if (!cli_rnp_setup(&rnp)) {
        throw std::runtime_error("Error: cli_rnp_setup");
    }

    cfg.load_defaults();
    cfg.set_str(CFG_HOMEDIR, "/Users/macos/.gnupg");
    if (!cli_cfg_set_keystore_info(cfg)) {
        throw std::runtime_error("fatal: cannot set keystore info");
    }
    if (!rnp.init(cfg)) {
        throw std::runtime_error("fatal: cannot initialise");
    }
    rnp.load_keyrings(true);
    rnp_ffi_set_pass_provider(rnp.ffi, example_pass_provider, this);

    ctxInitialized = true;
}

https://github.com/shemeshg/gpgme-cmake-example/blob/rnpLibSupport/libpgpfactory/LibGpgFactoryRnp.cpp

[ni4]

I see here 3 problems:

1. You don't check return result of the rnp_op_verify_execute(), which most likely fails in this scenario...
2. ...since you are reusing the same input which is already read till the end by rnp_decrypt() call.
3. You don't need to call rnp_decrypt() and rnp_verify_execute() - the second one will also output decrypted data, as well as populate signatures.

[shemeshg]

Thanks, it solved it.