Fix all flake 8 errors and warnings (except excluded and ignored files)

Signed-off-by: Christopher Arndt <[email protected]>

Author: SpotlightKid

examples/basic/contextmanager.py

@@ -7,9 +7,9 @@
 import time
 import rtmidi
 
-from rtmidi.midiconstants import *
+from rtmidi.midiconstants import NOTE_OFF, NOTE_ON
 
-NOTE = 60 # middle C
+NOTE = 60  # middle C
 
 midiout = rtmidi.MidiOut()
 

examples/basic/midiin_callback.py

@@ -8,13 +8,12 @@
 import sys
 import time
 
-import rtmidi
 from rtmidi.midiutil import open_midiport
 
 log = logging.getLogger('test_midiin_callback')
-
 logging.basicConfig(level=logging.DEBUG)
 
+
 class MidiInputHandler(object):
     def __init__(self, port):
         self.port = port

examples/basic/midiin_poll.py

@@ -8,7 +8,6 @@
 import sys
 import time
 
-import rtmidi
 from rtmidi.midiutil import open_midiport
 
 log = logging.getLogger('test_midiin_poll')

examples/basic/midiout.py

@@ -8,12 +8,10 @@
 import sys
 import time
 
-import rtmidi
 from rtmidi.midiutil import open_midiport
-from rtmidi.midiconstants import *
+from rtmidi.midiconstants import NOTE_OFF, NOTE_ON
 
 log = logging.getLogger('test_midiout')
-
 logging.basicConfig(level=logging.DEBUG)
 
 port = sys.argv[1] if len(sys.argv) > 1 else None
@@ -23,7 +21,7 @@
 except (EOFError, KeyboardInterrupt):
     sys.exit()
 
-note_on = [NOTE_ON, 60, 112] # channel 1, middle C, velocity 112
+note_on = [NOTE_ON, 60, 112]  # channel 1, middle C, velocity 112
 note_off = [NOTE_OFF, 60, 0]
 
 print("Sending NoteOn event.")

examples/basic/probe_ports.py

@@ -4,9 +4,9 @@
 #
 """Shows how to probe for available MIDI input and output ports."""
 
-import sys
-
-from rtmidi import *
+from rtmidi import (API_LINUX_ALSA, API_MACOSX_CORE, API_RTMIDI_DUMMY,
+                    API_UNIX_JACK, API_WINDOWS_MM, MidiIn, MidiOut,
+                    get_compiled_api)
 
 try:
     input = raw_input
@@ -15,10 +15,10 @@
     StandardError = Exception
 
 apis = {
-    API_MACOSX_CORE:  "OS X CoreMIDI",
-    API_LINUX_ALSA:   "Linux ALSA",
-    API_UNIX_JACK:    "Jack Client",
-    API_WINDOWS_MM:   "Windows MultiMedia",
+    API_MACOSX_CORE: "OS X CoreMIDI",
+    API_LINUX_ALSA: "Linux ALSA",
+    API_UNIX_JACK: "Jack Client",
+    API_WINDOWS_MM: "Windows MultiMedia",
     API_RTMIDI_DUMMY: "RtMidi Dummy"
 }
 
@@ -27,8 +27,8 @@
 for api, api_name in sorted(apis.items()):
     if api in available_apis:
         try:
-            if input("Probe ports using the %s API? (Y/n) " % api_name
-                    ).strip().lower() not in ['', 'y', 'yes']:
+            reply = input("Probe ports using the %s API? (Y/n) " % api_name)
+            if reply.strip().lower() not in ['', 'y', 'yes']:
                 continue
         except (KeyboardInterrupt, EOFError):
             print('')

examples/drumseq/drumseq.py

@@ -17,8 +17,10 @@
 from time import sleep, time as timenow
 
 import rtmidi
-from rtmidi.midiutil import open_midiport
-from rtmidi.midiconstants import *
+from rtmidi.midiutil import open_midioutput
+from rtmidi.midiconstants import (ALL_SOUND_OFF, BANK_SELECT_LSB,
+                                  BANK_SELECT_MSB, CHANNEL_VOLUME,
+                                  CONTROL_CHANGE, NOTE_ON, PROGRAM_CHANGE)
 
 
 FUNKYDRUMMER = """
@@ -98,13 +100,13 @@ class Drumpattern(object):
     """Container and iterator for a multi-track step sequence."""
 
     velocities = {
-        "-": None, # continue note
-        ".": 0,    # off
-        "+": 10,   # ghost
-        "s": 60,   # soft
-        "m": 100,  # medium
-        "x": 120,  # hard
-        }
+        "-": None,  # continue note
+        ".": 0,     # off
+        "+": 10,    # ghost
+        "s": 60,    # soft
+        "m": 100,   # medium
+        "x": 120,   # hard
+    }
 
     def __init__(self, pattern, kit=0, humanize=0):
         self.instruments = []
@@ -141,6 +143,7 @@ def playstep(self, midiout, channel=9):
                 if velocity > 0:
                     if self.humanize:
                         velocity += int(round(gauss(0, velocity * self.humanize)))
+
                     midiout.send_message([NOTE_ON | channel, note, max(1, velocity)])
                     self._notes[note] = velocity
 
@@ -152,22 +155,23 @@ def playstep(self, midiout, channel=9):
 
 def main(args=None):
     ap = argparse.ArgumentParser(description=__doc__.splitlines()[0])
-    ap.add_argument('-b', '--bpm', type=float, default=100,
-        help="Beats per minute (BPM) (default: %(default)s)")
-    ap.add_argument('-c', '--channel', type=int, default=10, metavar='CH',
-        help="MIDI channel (default: %(default)s)")
-    ap.add_argument('-p', '--port',
-        help="MIDI output port number (default: ask)")
-    ap.add_argument('-k', '--kit', type=int, metavar='KIT',
-        help="Drum kit MIDI program number (default: none)")
-    ap.add_argument('--bank-msb', type=int, metavar='MSB',
-        help="MIDI bank select MSB (CC#00) number (default: none)")
-    ap.add_argument('--bank-lsb', type=int, metavar='MSB',
-        help="MIDI bank select LSB (CC#32) number (default: none)")
-    ap.add_argument('-H', '--humanize', type=float, default=0.0, metavar='VAL',
-        help="Random velocity variation (float, default: 0, try ~0.03)")
-    ap.add_argument('pattern', nargs='?', type=argparse.FileType(),
-        help="Drum pattern file (default: use built-in pattern)")
+    aadd = ap.add_argument
+    aadd('-b', '--bpm', type=float, default=100,
+         help="Beats per minute (BPM) (default: %(default)s)")
+    aadd('-c', '--channel', type=int, default=10, metavar='CH',
+         help="MIDI channel (default: %(default)s)")
+    aadd('-p', '--port',
+         help="MIDI output port number (default: ask)")
+    aadd('-k', '--kit', type=int, metavar='KIT',
+         help="Drum kit MIDI program number (default: none)")
+    aadd('--bank-msb', type=int, metavar='MSB',
+         help="MIDI bank select MSB (CC#00) number (default: none)")
+    aadd('--bank-lsb', type=int, metavar='MSB',
+         help="MIDI bank select LSB (CC#32) number (default: none)")
+    aadd('-H', '--humanize', type=float, default=0.0, metavar='VAL',
+         help="Random velocity variation (float, default: 0, try ~0.03)")
+    aadd('pattern', nargs='?', type=argparse.FileType(),
+         help="Drum pattern file (default: use built-in pattern)")
 
     args = ap.parse_args(args if args is not None else sys.argv[1:])
 
@@ -180,9 +184,11 @@ def main(args=None):
     pattern = Drumpattern(pattern, kit=kit, humanize=args.humanize)
 
     try:
-        midiout, port_name = open_midiport(args.port, "output",
+        midiout, port_name = open_midioutput(
+            args.port,
             api=rtmidi.API_UNIX_JACK,
-            client_name="drumseq", port_name="MIDI Out")
+            client_name="drumseq",
+            port_name="MIDI Out")
     except (EOFError, KeyboardInterrupt):
         return
 
@@ -196,7 +202,7 @@ def main(args=None):
     except KeyboardInterrupt:
         print('')
     finally:
-        seq.done = True # And kill it.
+        seq.done = True  # And kill it.
         seq.join()
         del midiout
         print("Done")

examples/midi2command/midi2command.py

@@ -40,8 +40,9 @@
 import yaml
 
 import rtmidi
-from rtmidi.midiutil import open_midiport
-from rtmidi.midiconstants import *
+from rtmidi.midiutil import open_midiinput
+from rtmidi.midiconstants import (CHANNEL_PRESSURE, CONTROLLER_CHANGE, NOTE_ON, NOTE_OFF,
+                                  PITCH_BEND, POLY_PRESSURE, PROGRAM_CHANGE)
 
 
 log = logging.getLogger('midi2command')
@@ -63,8 +64,8 @@
 
 
 class Command(object):
-    def __init__(self, name='', description='', status=0xB0, channel=None,
-            data=None, command=None):
+    def __init__(self, name='', description='', status=0xB0, channel=None, data=None,
+                 command=None):
         self.name = name
         self.description = description
         self.status = status
@@ -106,7 +107,7 @@ def __call__(self, event, data=None):
             data2 = event[2]
 
         log.debug("[%s] @%i CH:%2s %02X %s %s", self.port, self._wallclock,
-            channel or '-', status, data1, data2 or '')
+                  channel or '-', status, data1, data2 or '')
 
         # Look for matching command definitions
         cmd = self.lookup_command(status, channel, data1, data2)
@@ -165,7 +166,7 @@ def load_config(self, filename):
                         int(cmd.status)
                     except:
                         log.error("Unknown status '%s'. Ignoring command",
-                            cmd.status)
+                                  cmd.status)
 
                 log.debug("Config: %s\n%s\n", cmd.name, cmd.description)
                 self.commands.setdefault(status, []).append(cmd)
@@ -180,25 +181,28 @@ def main(args=None):
 
     """
     parser = argparse.ArgumentParser(description=__doc__.splitlines()[0])
-    parser.add_argument('-b',  '--backend',
-        choices=sorted(BACKEND_MAP),
-        help='MIDI backend API (default: OS dependant)')
-    parser.add_argument('-p',  '--port',
-        help='MIDI input port name or number (default: open virtual input)')
-    parser.add_argument('-v',  '--verbose',
-        action="store_true", help='verbose output')
-    parser.add_argument(dest='config', metavar="CONFIG",
-        help='Configuration file in YAML syntax.')
+    padd = parser.add_argument
+    padd('-b', '--backend', choices=sorted(BACKEND_MAP),
+         help='MIDI backend API (default: OS dependant)')
+    padd('-p', '--port',
+         help='MIDI input port name or number (default: open virtual input)')
+    padd('-v', '--verbose',
+         action="store_true", help='verbose output')
+    padd(dest='config', metavar="CONFIG",
+         help='Configuration file in YAML syntax.')
 
     args = parser.parse_args(args if args is not None else sys.argv[1:])
 
     logging.basicConfig(format="%(name)s: %(levelname)s - %(message)s",
-        level=logging.DEBUG if args.verbose else logging.WARNING)
+                        level=logging.DEBUG if args.verbose else logging.INFO)
 
     try:
-        midiin, port_name = open_midiport(args.port, use_virtual=True,
+        midiin, port_name = open_midiinput(
+            args.port,
+            use_virtual=True,
             api=BACKEND_MAP.get(args.backend, rtmidi.API_UNSPECIFIED),
-            client_name='midi2command', port_name='MIDI input')
+            client_name='midi2command',
+            port_name='MIDI input')
     except (IOError, ValueError) as exc:
         return "Could not open MIDI input: %s" % exc
     except (EOFError, KeyboardInterrupt):

examples/midifilter/__main__.py

@@ -18,10 +18,9 @@
 except ImportError:  # Python 3
     import queue
 
-import rtmidi
 from rtmidi.midiutil import open_midiport
 
-from .filters import *
+from .filters import MapControllerValue, MonoPressureToCC, Transpose
 
 
 log = logging.getLogger("midifilter")
@@ -67,25 +66,26 @@ def stop(self):
 
 def main(args=None):
     parser = argparse.ArgumentParser(prog='midifilter', description=__doc__)
-    parser.add_argument('-m',  '--mpresstocc', action="store_true",
-        help='Map mono pressure (channel aftertouch) to CC')
-    parser.add_argument('-r',  '--mapccrange', action="store_true",
-        help='Map controller value range to min/max value range')
-    parser.add_argument('-t',  '--transpose', action="store_true",
-        help='Transpose note on/off event note values')
-    parser.add_argument('-i',  '--inport',
-        help='MIDI input port number (default: ask)')
-    parser.add_argument('-o',  '--outport',
-        help='MIDI output port number (default: ask)')
-    parser.add_argument('-v',  '--verbose', action="store_true",
-        help='verbose output')
-    parser.add_argument('filterargs', nargs="*", type=int,
-        help='MIDI filter argument(s)')
+    padd = parser.add_argument
+    padd('-m', '--mpresstocc', action="store_true",
+         help='Map mono pressure (channel aftertouch) to CC')
+    padd('-r', '--mapccrange', action="store_true",
+         help='Map controller value range to min/max value range')
+    padd('-t', '--transpose', action="store_true",
+         help='Transpose note on/off event note values')
+    padd('-i', '--inport',
+         help='MIDI input port number (default: ask)')
+    padd('-o', '--outport',
+         help='MIDI output port number (default: ask)')
+    padd('-v', '--verbose', action="store_true",
+         help='verbose output')
+    padd('filterargs', nargs="*", type=int,
+         help='MIDI filter argument(s)')
 
     args = parser.parse_args(args if args is not None else sys.argv[1:])
 
     logging.basicConfig(format="%(name)s: %(levelname)s - %(message)s",
-        level=logging.DEBUG if args.verbose else logging.WARNING,)
+                        level=logging.DEBUG if args.verbose else logging.INFO)
 
     try:
         midiin, inport_name = open_midiport(args.inport, "input")

examples/midifilter/filters.py

@@ -4,6 +4,10 @@
 #
 """Collection MIDI filter classes."""
 
+from rtmidi.midiconstants import (BANK_SELECT_LSB, BANK_SELECT_MSB, CHANNEL_PRESSURE,
+                                  CONTROLLER_CHANGE, NOTE_ON, NOTE_OFF, PROGRAM_CHANGE)
+
+
 __all__ = (
     'CCToBankChange',
     'MapControllerValue',
@@ -12,8 +16,6 @@
     'Transpose',
 )
 
-from rtmidi.midiconstants import *
-
 
 class MidiFilter(object):
     """ABC for midi filters."""

examples/osc2midi/device.py

@@ -4,17 +4,13 @@
 #
 """MIDI device abstraction classes."""
 
-__all__ = [
-    "RtMidiDevice"
-]
-
 import logging
 import time
 
-import rtmidi
+from rtmidi.midiutil import open_midioutput
 
-from rtmidi.midiutil import open_midiport
 
+__all__ = ["RtMidiDevice"]
 log = logging.getLogger(__name__)
 
 
@@ -31,8 +27,8 @@ def __str__(self):
         return self.portname
 
     def open_output(self):
-        self._output, self.portname = open_midiport(self.port, "output",
-            interactive=False, client_name=self.name)
+        self._output, self.portname = open_midioutput(self.port, interactive=False,
+                                                      client_name=self.name)
 
     def close_output(self):
         if self._output is not None: