Skip to content
This repository has been archived by the owner on Mar 23, 2024. It is now read-only.

Make AudioObject+Helpers extension public #47

Open
jolonf opened this issue Aug 16, 2021 · 2 comments
Open

Make AudioObject+Helpers extension public #47

jolonf opened this issue Aug 16, 2021 · 2 comments

Comments

@jolonf
Copy link
Contributor

jolonf commented Aug 16, 2021

The getProperty functions in the AudioObject+Helpers.swift file are handy and would only need to be redefined elsewhere if they aren't public.

@ryanfrancesconi
Copy link
Collaborator

That seems like it would be a good idea. @rnine ?

@rnine
Copy link
Owner

rnine commented Aug 25, 2021

Fine by me. However, these functions are not documented, so maybe either they'll need some documentation, or simply use /// :nodoc: so jazzy will ignore them when generating HTML docs. Also, the extension should be moved from Internal/Extensions to Public/Extensions directory to keep intent clear.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants