Minor edits

Author: eprbell

tests/test_configuration.py

@@ -311,8 +311,6 @@ def test_internal_id(self) -> None:
 
         with self.assertRaisesRegex(RP2TypeError, "Parameter name is not a string: .*"):
             self._configuration.type_check_internal_id(None, 10)  # type: ignore
-        with self.assertRaisesRegex(RP2ValueError, "Parameter 'internal_id' has non-positive value .*"):
-            self._configuration.type_check_internal_id("internal_id", -23)
         with self.assertRaisesRegex(RP2TypeError, "Parameter 'internal_id' has non-integer value .*"):
             self._configuration.type_check_internal_id("internal_id", 7.7)  # type: ignore
         with self.assertRaisesRegex(RP2TypeError, "Parameter 'internal_id' has non-integer value .*"):

tests/test_gain_loss.py

@@ -47,9 +47,9 @@ def setUp(self) -> None:
             "BuY",
             RP2Decimal("10000"),
             RP2Decimal("2.0002"),
-            RP2Decimal("20"),
-            RP2Decimal("20002"),
-            RP2Decimal("20022"),
+            fiat_fee=RP2Decimal("20"),
+            fiat_in_no_fee=RP2Decimal("20002"),
+            fiat_in_with_fee=RP2Decimal("20022"),
             internal_id=10,
         )
         self._in_buy2 = InTransaction(
@@ -61,7 +61,7 @@ def setUp(self) -> None:
             "BuY",
             RP2Decimal("10500"),
             RP2Decimal("0.8"),
-            RP2Decimal("10"),
+            fiat_fee=RP2Decimal("10"),
             internal_id=11,
         )
         self._in_buy3 = InTransaction(
@@ -73,7 +73,7 @@ def setUp(self) -> None:
             "BuY",
             RP2Decimal("1300"),
             RP2Decimal("1.5"),
-            RP2Decimal("20"),
+            fiat_fee=RP2Decimal("20"),
             internal_id=12,
         )
         self._in_interest = InTransaction(
@@ -85,7 +85,7 @@ def setUp(self) -> None:
             "interest",
             RP2Decimal("11000"),
             RP2Decimal("0.1"),
-            RP2Decimal("0"),
+            fiat_fee=RP2Decimal("0"),
             internal_id=14,
         )
         self._out: OutTransaction = OutTransaction(
@@ -319,7 +319,7 @@ def test_bad_gain_loss(self) -> None:
                 "BuY",
                 RP2Decimal("1300"),
                 RP2Decimal("1.5"),
-                RP2Decimal("20"),
+                fiat_fee=RP2Decimal("20"),
                 internal_id=11,
             )
             GainLoss(self._configuration, self._accounting_method, RP2Decimal("0.1"), self._out, in_transaction)

tests/test_gain_loss_set.py

@@ -94,7 +94,7 @@ def _initialize_transactions(cls, asset: str) -> None:
             "BUY",
             RP2Decimal("11000"),
             RP2Decimal("1"),
-            RP2Decimal("100.00"),
+            fiat_fee=RP2Decimal("100.00"),
             internal_id=4,
         )
         cls._in2[asset] = InTransaction(
@@ -106,7 +106,7 @@ def _initialize_transactions(cls, asset: str) -> None:
             "INTEREST",
             RP2Decimal("12000.0"),
             RP2Decimal("2.0"),
-            RP2Decimal("0"),
+            fiat_fee=RP2Decimal("0"),
             internal_id=3,
         )
         cls._in6[asset] = InTransaction(
@@ -118,7 +118,7 @@ def _initialize_transactions(cls, asset: str) -> None:
             "INTEREST",
             RP2Decimal("13000.0"),
             RP2Decimal("3"),
-            RP2Decimal("0"),
+            fiat_fee=RP2Decimal("0"),
             internal_id=7,
         )
         cls._in5[asset] = InTransaction(
@@ -130,7 +130,7 @@ def _initialize_transactions(cls, asset: str) -> None:
             "BUY",
             RP2Decimal("14000.0"),
             RP2Decimal("4.0"),
-            RP2Decimal("400"),
+            fiat_fee=RP2Decimal("400"),
             internal_id=6,
         )
         cls._in4[asset] = InTransaction(
@@ -142,7 +142,7 @@ def _initialize_transactions(cls, asset: str) -> None:
             "BUY",
             RP2Decimal("15000.0"),
             RP2Decimal("5.0"),
-            RP2Decimal("500"),
+            fiat_fee=RP2Decimal("500"),
             internal_id=5,
         )
         cls._out15[asset] = OutTransaction(
@@ -390,7 +390,7 @@ def test_bad_gain_loss_set(self) -> None:
                 "INTEREST",
                 RP2Decimal("12000.0"),
                 RP2Decimal("2.0"),
-                RP2Decimal("0"),
+                fiat_fee=RP2Decimal("0"),
                 internal_id=3,
             )
             gain_loss_set.add_entry(GainLoss(self._configuration, self._accounting_method, RP2Decimal("0.2"), out15, in_transaction_test))