Skip to content

Commit dd3c42c

Browse files
committed
Fix module and path of generated BaseResolver
1 parent 3c7875d commit dd3c42c

File tree

3 files changed

+7
-2
lines changed

3 files changed

+7
-2
lines changed

Diff for: lib/generators/graphql/install_generator.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ def create_folder_structure
106106
end
107107

108108
# All resolvers are defined as living in their own module, including this class.
109-
template("base_resolver.erb", "#{options[:directory]}/resolvers/base.rb")
109+
template("base_resolver.erb", "#{options[:directory]}/resolvers/base_resolver.rb")
110110

111111
# Note: You can't have a schema without the query type, otherwise introspection breaks
112112
template("query_type.erb", "#{options[:directory]}/types/query_type.rb")

Diff for: lib/generators/graphql/templates/base_resolver.erb

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<% module_namespacing_when_supported do -%>
2-
module Types
2+
module Resolvers
33
class BaseResolver < GraphQL::Schema::Resolver
44
end
55
end

Diff for: spec/integration/rails/generators/graphql/install_generator_spec.rb

+5
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,11 @@ def refute_file(path)
4040
assert_includes contents, expected_graphiql_route
4141
end
4242

43+
assert_file "app/graphql/resolvers/base_resolver.rb" do |contents|
44+
assert_includes contents, "module Resolvers"
45+
assert_includes contents, "class BaseResolver < GraphQL::Schema::Resolver"
46+
end
47+
4348
assert_file "Gemfile" do |contents|
4449
assert_match %r{gem ('|")graphiql-rails('|"), :?group(:| =>) :development}, contents
4550
end

0 commit comments

Comments
 (0)