From 1237cf78d5b63e30ccde4b5d366bb8cdb54ebe13 Mon Sep 17 00:00:00 2001 From: Thejaswi Rao Date: Wed, 22 May 2019 22:00:56 -0700 Subject: [PATCH] updated build instructions with installing clang-format, both for users using conda env and not --- BUILD.md | 2 +- cpp/README.md | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/BUILD.md b/BUILD.md index 1a91d64a84..10f2fd5d63 100644 --- a/BUILD.md +++ b/BUILD.md @@ -11,7 +11,7 @@ To install cuML from source, ensure the dependencies are met: 5. Cython (>= 0.29) 6. gcc (>=5.4.0) 7. BLAS - Any BLAS compatible with cmake's [FindBLAS](https://cmake.org/cmake/help/v3.12/module/FindBLAS.html). Note that the blas has to be installed to the same folder system as cmake, for example if using conda installed cmake, the blas implementation should also be installed in the conda environment. -8. libclang conda package (= 8.0.0). Installation command: `conda install -c teju85 libclang`. This is needed to enforce uniform C++ coding style across the project. +8. clang-format (= 8.0.0) - This is needed if you are building this C++ library from source. For the ones using conda environment, our rapids official channel should have this available, until then, the installation command is `conda install -c teju85 libclang`. For the ones not using conda, please install this version using your favorite packaging SW (viz., yum, apt-get, ...). This is needed to enforce uniform C++ coding style across the project. ## Installing from Source: diff --git a/cpp/README.md b/cpp/README.md index b141336789..371815090c 100644 --- a/cpp/README.md +++ b/cpp/README.md @@ -19,6 +19,7 @@ The test folder has subfolders that reflect this distinction between the compone 3. CUDA (>= 9.2) 4. gcc (>=5.4.0) 5. BLAS - Any BLAS compatible with cmake's [FindBLAS](https://cmake.org/cmake/help/v3.12/module/FindBLAS.html). Note that the blas has to be installed to the same folder system as cmake, for example if using conda installed cmake, the blas implementation should also be installed in the conda environment. +6. clang-format (= 8.0.0) - This is needed if you are building this C++ library from source. For the ones using conda environment, our rapids official channel should have this available, until then, the installation command is `conda install -c teju85 libclang`. For the ones not using conda, please install this version using your favorite packaging SW (viz., yum, apt-get, ...). This is needed to enforce uniform C++ coding style across the project. ### Building cuML: