Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Cucumber Expressions #89

Open
drkstr101 opened this issue Sep 9, 2020 · 2 comments
Open

Add Support for Cucumber Expressions #89

drkstr101 opened this issue Sep 9, 2020 · 2 comments

Comments

@drkstr101
Copy link
Contributor

drkstr101 commented Sep 9, 2020

Support for Cucumber Expressions has been added to recent versions of cucumber-jvm, which cause the stepmatcher to fail in the current release. It took those folks a little over a year to implement the feature, so it seems like it will be quite involved.

This work should most likely happen as a separate point release after next, which addresses the immediate issue of the validation routine bailing with a runtime exception. This is accomplished by checking the first character of the annotationValue prior to attempting the regex match catching any PatternSyntaxException that results from the match and defaulting to false (no match found). The next step would be to attempt to parse the annotationValue as a Cucumber Expression to see if it matches the provided step description.

@rlogiacco
Copy link
Owner

We should consider integrating with the internal parser/matcher instead of using our own:

  • it's hard to create an EBNF version of the Gherkin syntax (as you have experienced first-hand)
  • it's tough to follow the Gherkin and Cucumber development rate (it's just the 2 of us)

@drkstr101
Copy link
Contributor Author

Yes I think you are right. It would be ideal if step matching was consistent with underlying library used to execute the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants