-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Difficult to output larger images #11
Comments
@hswaffield I am working on a fork of this repository that massively cleans up the code: https://github.com/zacharynevin/GANGogh/tree/release/custom. I have tried my best to remove most of the magic numbers. In addition, I have given it the following advantages:
This is still a work in progress and hasn't been tested, so any commits or issues are appreciated (especially where layer dimensions are concerned). |
Thanks for your comment! |
Hi @hswaffield, just a quick warning that I haven't tested this yet. Its still very much a work in progress. However, any PRs with fixes would be welcome. Also, TFRecords are very straightforward to set up. Here is an example gist: https://gist.github.com/zacharynevin/d9c6aa21a2d52299dfc56c12804d6770 |
Hi @zacharynevin, do you still have the code around? |
@orestis-z I don't. For some reason I cleaned up this repository during a purge of old code that I never worked on. Sorry about that! I promise to be a better open-source citizen. However, here is another repository I didn't delete that uses essentially the equivalent coding style: https://github.com/zacharynevin/StackGAN. In fact to make this repo I think I just copied my |
@zacharynevin Any chance you can reupload your fork if you still have the code available somewhere? Thanks. |
After running your code successfully to produce 64 x 64 images, I'm trying to output larger images, 128 x 128, but I have been running into a number of problems.
The first is that there are a lot of magic numbers, with no explanation of what they mean:
e.g. "844dim2" - I tried multiplying dim by 4 here (the square of 2x is 4 * square of x)
and that seems to work, but I'm just guessing because it's not clear where the numbers come from.
There are many areas where the number 64 appears, and it's not clear if it really should be 64, or if it should be the dimension.
To output 128 x 128 images, does the model dimensionality need to be 128?
other issues:
raise ValueError("GraphDef cannot be larger than 2GB.")
ValueError: GraphDef cannot be larger than 2GB. ... I'm running this on a Titan Xp GPU, which has 12 GB of memory, so there surely has to be a way that I'm not limited by this constraint. Any idea of that that would be?
this occurs at:
File "GANGogh/GANgogh.py", line 378, in
_x_r = session.run(real_data, feed_dict={all_real_data_conv: _x})
I'm new to tensor flow so this is rather scary and intimidating.
So any guidance on how to simply change the code so that it can output larger dimension images would be greatly appreciated, because it seemed initially that the task would be straightforward, only requiring a few variable changes, relating to DIM, OUTPUT_DIM, ETC...
I think this project is really cool, and really appreciated your medium article... it's what first exposed me to GANs.
Any feedback on how to approach this would be greatly appreciated.
Thanks
The text was updated successfully, but these errors were encountered: