Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minifying not working #2

Open
iamsoaw opened this issue Mar 17, 2014 · 4 comments
Open

Minifying not working #2

iamsoaw opened this issue Mar 17, 2014 · 4 comments

Comments

@iamsoaw
Copy link

iamsoaw commented Mar 17, 2014

Hello. Minifying not working, it seems some problem with submodule vendor/matthiasmullie/minify, it does not exists.

@rkingon
Copy link
Owner

rkingon commented Mar 17, 2014

Indeed.

For now, you can grab that here: https://github.com/matthiasmullie/minify

I would honestly not even use this plugin anymore- I have a much better time using grunt.

@iamsoaw
Copy link
Author

iamsoaw commented Mar 17, 2014

Do you use grunt right from Craft CMS (as a plugin), or run it manually/from your editor?

@rkingon
Copy link
Owner

rkingon commented Mar 17, 2014

i use it in the cli, "grunt watch" to look for chages as i am dev'ing.

you can also use a plugin like: https://github.com/hollandben/grunt-cache-bust to handle asset hash.

there is another which output's a json file of what the asset hash's are, i was going to write a little twig extension to read that json file so you can use a craft tag to output your css/js and it'll automatically handle the naming convention

@iamsoaw
Copy link
Author

iamsoaw commented Mar 18, 2014

Yes, these tools are great, and I love Node.js, but they are external. I believe that the power of Craft is in its integrity, everything is inside the core and we rely on PHP functions and modules. That's why I like your plugin over any other external tools.

PS: Please check your Facebook, I have sent you a message regarding this plugin (not a bugreport).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants