From 0fb11a7321277c223a124d2a929a4f074c006143 Mon Sep 17 00:00:00 2001
From: Matt Kotsenas <Matt.Kotsenas@gmail.com>
Date: Mon, 3 Jun 2024 09:42:04 -0700
Subject: [PATCH] Set package README, license expression, and development
 dependency (#41)

* Upgrade package license to expression

Using an expression for the well-known BSD-3 Clause license instead of a
URL (which makes it look like the package is using a custom license) and simplifes
compliance for users.

* Add package readme

* Mark package as a development dependency
---
 .../PackageTests.Baseline#contents.verified.txt              | 1 +
 .../PackageTests.Baseline#manifest.verified.nuspec           | 5 ++++-
 Source/Moq.Analyzers/Moq.Analyzers.csproj                    | 5 ++++-
 3 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/Source/Moq.Analyzers.Test/PackageTests.Baseline#contents.verified.txt b/Source/Moq.Analyzers.Test/PackageTests.Baseline#contents.verified.txt
index d25f0afc..c17b1ab4 100644
--- a/Source/Moq.Analyzers.Test/PackageTests.Baseline#contents.verified.txt
+++ b/Source/Moq.Analyzers.Test/PackageTests.Baseline#contents.verified.txt
@@ -1,5 +1,6 @@
 /
 |-- Moq.Analyzers.nuspec
+|-- README.md
 |-- analyzers
 |   |-- dotnet
 |   |   |-- cs
diff --git a/Source/Moq.Analyzers.Test/PackageTests.Baseline#manifest.verified.nuspec b/Source/Moq.Analyzers.Test/PackageTests.Baseline#manifest.verified.nuspec
index 271f6ce6..070173ce 100644
--- a/Source/Moq.Analyzers.Test/PackageTests.Baseline#manifest.verified.nuspec
+++ b/Source/Moq.Analyzers.Test/PackageTests.Baseline#manifest.verified.nuspec
@@ -3,7 +3,10 @@
     <id>Moq.Analyzers</id>
     <version>********</version>
     <authors>Andrey "Litee" Lipatkin</authors>
-    <licenseUrl>https://github.com/Litee/moq.analyzers/blob/master/LICENSE</licenseUrl>
+    <developmentDependency>true</developmentDependency>
+    <license type="expression">BSD-3-Clause</license>
+    <licenseUrl>https://licenses.nuget.org/BSD-3-Clause</licenseUrl>
+    <readme>README.md</readme>
     <projectUrl>https://github.com/Litee/moq.analyzers</projectUrl>
     <description>Roslyn analyzer that helps to write unit tests using Moq mocking library by highlighting typical errors and suggesting quick fixes. Port of Resharper extension to Roslyn. Find the full list of detected issues at project GitHub page.</description>
     <releaseNotes>Upgraded to support Visual Studio 2019</releaseNotes>
diff --git a/Source/Moq.Analyzers/Moq.Analyzers.csproj b/Source/Moq.Analyzers/Moq.Analyzers.csproj
index de1c4cc0..4cf7618e 100644
--- a/Source/Moq.Analyzers/Moq.Analyzers.csproj
+++ b/Source/Moq.Analyzers/Moq.Analyzers.csproj
@@ -31,13 +31,15 @@
   <PropertyGroup>
     <PackageId>Moq.Analyzers</PackageId>
     <Authors>Andrey "Litee" Lipatkin</Authors>
-    <PackageLicenseUrl>https://github.com/Litee/moq.analyzers/blob/master/LICENSE</PackageLicenseUrl>
+    <PackageLicenseExpression>BSD-3-Clause</PackageLicenseExpression>
     <PackageProjectUrl>https://github.com/Litee/moq.analyzers</PackageProjectUrl>
     <PackageRequireLicenseAcceptance>false</PackageRequireLicenseAcceptance>
+    <PackageReadmeFile>README.md</PackageReadmeFile>
     <Description>Roslyn analyzer that helps to write unit tests using Moq mocking library by highlighting typical errors and suggesting quick fixes. Port of Resharper extension to Roslyn. Find the full list of detected issues at project GitHub page.</Description>
     <PackageReleaseNotes>Upgraded to support Visual Studio 2019</PackageReleaseNotes>
     <Copyright>2015-2019 Andrey Lipatkin</Copyright>
     <PackageTags>moq, mock, test, analyzers</PackageTags>
+    <DevelopmentDependency>true</DevelopmentDependency> 
     <NoPackageAnalysis>true</NoPackageAnalysis>
     <GeneratePackageOnBuild>true</GeneratePackageOnBuild>
   </PropertyGroup>
@@ -62,6 +64,7 @@
   </ItemGroup>
 
   <ItemGroup>
+    <None Include="$(RepoRoot)\README.md" Pack="true" PackagePath="/"/>
     <None Update="tools\*.ps1" CopyToOutputDirectory="Always" Pack="true" PackagePath="" />
     <None Include="$(OutputPath)\$(AssemblyName).dll" Pack="true" PackagePath="analyzers/dotnet/cs" Visible="false" />
   </ItemGroup>