Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is interfacer supposed to be slow? #35

Open
OscarVanL opened this issue Jan 24, 2022 · 1 comment
Open

Is interfacer supposed to be slow? #35

OscarVanL opened this issue Jan 24, 2022 · 1 comment
Labels
help wanted performance

Comments

@OscarVanL
Copy link

OscarVanL commented Jan 24, 2022 •
edited
Loading

We have noticed that go generate takes awfully long since we started using interfacer. Compared to mockgen, interfacer seems to take several orders of magnitude longer to run per file.

Is this by design/unavoidable or is this a bug?
@rjeczalik
Copy link
Owner

Is this by design/unavoidable or is this a bug?

There are no optimization in the interfacer at all, like caching loaded packages etc. Definitely it can be improved performance-wise.

stgraham2000 pushed a commit to Ioka-Technologies/interfaces that referenced this issue Jun 19, 2023
Fixes rjeczalik#35: Slow to generate interfaces
7e4eb44 
Migrate from using the older `loader` package in golang
tools to the new `packages` package in golang tools.  The
previous `loader` package does not support modules and
after switching from `loader` to `packages` it modified
an execution that took over 10s to under 1s.
stgraham2000 added a commit to Ioka-Technologies/interfaces that referenced this issue Jun 19, 2023
@stgraham2000
Merge pull request #1 from Ioka-Technologies/stgraham2000/35_migrate_…
2492b56 
…from_loader_to_packages

Fixes rjeczalik#35: Slow to generate interfaces
stgraham2000 pushed a commit to Ioka-Technologies/interfaces that referenced this issue Jun 21, 2023
Fixes rjeczalik#35: Slow to generate interfaces
b679cee 
Migrate from using the older `loader` package in golang
tools to the new `packages` package in golang tools.  The
previous `loader` package does not support modules and
after switching from `loader` to `packages` it modified
an execution that took over 10s to under 1s.
stgraham2000 added a commit to Ioka-Technologies/interfaces that referenced this issue Jun 21, 2023
@stgraham2000
Merge pull request #2 from Ioka-Technologies/stgraham2000/35_migrate_…
f5b5bd6 
…from_loader_to_packages

Fixes rjeczalik#35: Slow to generate interfaces
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rjeczalik @OscarVanL