Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autodetect asm.cpu whenever possible #4196

Draft
wants to merge 8 commits into
base: dev
Choose a base branch
from
Draft

Autodetect asm.cpu whenever possible #4196

wants to merge 8 commits into from
+273 −1

Conversation

valdaarhun
Copy link
Contributor

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

get_cpu_arm() scans through the ".ARM.attributes" section of the ELF file to find the "aeabi" subsection. This subsection contains general build attributes that records data about the compatibility of the ELF file. The relevant tags in this subsection (eg: Tag_CPU_arch) can help determine asm.cpu.

References:

Test plan

Will think of one after finishing the implementation.

Closing issues

Fixes #3747

@valdaarhun valdaarhun force-pushed the asm_cpu branch 2 times, most recently from 374bb57 to 0d4230d Compare February 7, 2024 20:31
XVilka
XVilka requested changes Feb 8, 2024
View reviewed changes
Copy link
Member

@XVilka XVilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this direction is correct. Once you finish it, please also add a test.

@valdaarhun
Copy link
Contributor Author

Yes, this direction is correct. Once you finish it, please also add a test.

Sure, I'll do that.

@XVilka
Copy link
Member

XVilka commented Feb 15, 2024

@valdaarhun do you have any progress on this? It would be nice to include it into the upcoming 0.7.0 release

@valdaarhun
Copy link
Contributor Author

@valdaarhun do you have any progress on this?

Hi. Yes, I have made some progress. There's not much left.

It would be nice to include it into the upcoming 0.7.0 release

Got it. I should be able to finish the implementation soon.

@valdaarhun
Copy link
Contributor Author

TODO:

  • Parse tags correctly in read_arm_build_attributes(). Some tags such as TAG_COMPATIBILITY have a few quirks but handling them should not be too hard.
  • Testing

XVilka
XVilka requested changes Feb 20, 2024
View reviewed changes
librz/bin/format/elf/elf_info.c Outdated Show resolved Hide resolved
DMaroo
DMaroo reviewed Feb 23, 2024
View reviewed changes
librz/bin/format/elf/elf_info.c Show resolved Hide resolved
librz/bin/format/elf/glibc_elf.h Outdated Show resolved Hide resolved
@XVilka
Copy link
Member

XVilka commented Mar 4, 2024

@valdaarhun hi, have you had any progress on this PR?

@valdaarhun
Copy link
Contributor Author

@valdaarhun hi, have you had any progress on this PR?

Hi. Sorry, I wasn't able to give much time to this last week. I do have some more commits to push. I'll push those for review. There's some more implementation left to do in the parser. I'll finish that up as well.

@valdaarhun
ARM: Implement search for public (aeabi) attributes subsection
e38c6ed 
get_cpu_arm() scans through the ".ARM.attributes" section of the
ELF file to find the "aeabi" subsection. This subsection contains
general build attributes that records data about the compatibility
of the ELF file.
@valdaarhun
ARM: Parse aeabi subsection
aead5d7 
Rename "read_arm_attributes_section()" to "read_arm_aeabi_section()".
This function searches for the "TAG_FILE" sub-subsection.
@valdaarhun
ARM: Add macros defining tags in the public attributes subsection
5075a5f 
Each tag's value is defined as a null-terminated string or a
uleb128-encoded number. This info will be required while
searching for "TAG_CPU_ARCH" and "Tag_CPU_ARCH_PROFILE" in
the "ARM_TAG_FILE" sub-subsection.
@valdaarhun
ARM: Add macros for ARM CPU arch version and profile
d6e0142
@valdaarhun
Minor changes in ARM tags
943892f
@valdaarhun
ARM: Read arm build attributes
cd134e2 
* Read arm build attributes
* Incorporate reviewed changes
@valdaarhun
ARM: Add structure for arm cpu translation
2b71498
@valdaarhun
ARM: Get arch name
9dbf207
XVilka
XVilka requested changes Mar 25, 2024
View reviewed changes
Copy link
Member

@XVilka XVilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It breaks DWARF profile loading in some of the tests in its current state:

[XX] db/cmd/dwarf "ARM types"
RZ_NOPLUGINS=1 /usr/bin/rizin -escr.utf8=0 -escr.color=0 -escr.interactive=0 -eflirt.sigdb.load.system=false -eflirt.sigdb.load.home=false -N -Qc 'aaa
afvl @ dbg.main
pdf @ dbg.new_some
aaa
' bins/elf/test_app2/test_app2.elf
-- stdout
--- expected
+++ actual
@@ -4,15 +4,15 @@
 var int32_t var_2ch @ stack - 0x2c
 var int32_t var_1ch @ stack - 0x1c
 var some_t *s @ stack - 0x1a
-arg int argc @ r0
-arg char **argv @ r1
-var struct Some *gg @ r2
+arg int argc @ reg0
+arg char **argv @ reg1
+var struct Some *gg @ reg2
 var float a @ ...
 var float b @ ...
 var double c @ ...
             ; CALL XREFS from dbg.main @ 0x817c, 0x8184
 / some_t * new_some()
-|           ; var struct Some *n @ r4
+|           ; var struct Some *n @ reg4

@XVilka XVilka added this to the 0.8.0 milestone Mar 25, 2024
@valdaarhun
Copy link
Contributor Author

It breaks DWARF profile loading in some of the tests in its current state:

[XX] db/cmd/dwarf "ARM types"
RZ_NOPLUGINS=1 /usr/bin/rizin -escr.utf8=0 -escr.color=0 -escr.interactive=0 -eflirt.sigdb.load.system=false -eflirt.sigdb.load.home=false -N -Qc 'aaa
afvl @ dbg.main
pdf @ dbg.new_some
aaa
' bins/elf/test_app2/test_app2.elf
-- stdout
--- expected
+++ actual
@@ -4,15 +4,15 @@
 var int32_t var_2ch @ stack - 0x2c
 var int32_t var_1ch @ stack - 0x1c
 var some_t *s @ stack - 0x1a
-arg int argc @ r0
-arg char **argv @ r1
-var struct Some *gg @ r2
+arg int argc @ reg0
+arg char **argv @ reg1
+var struct Some *gg @ reg2
 var float a @ ...
 var float b @ ...
 var double c @ ...
             ; CALL XREFS from dbg.main @ 0x817c, 0x8184
 / some_t * new_some()
-|           ; var struct Some *n @ r4
+|           ; var struct Some *n @ reg4

I am not sure why this is happening. I'll investigate this further.

@XVilka
Copy link
Member

XVilka commented May 15, 2024

@wargio, we will need the same approach for MIPS files. Apparently, corresponding ELF files contain more precise information about the CPU used than we currently process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DMaroo DMaroo DMaroo left review comments

@XVilka XVilka XVilka requested changes

@JulyMoon87 JulyMoon87 JulyMoon87 approved these changes

@ret2libc ret2libc Awaiting requested review from ret2libc ret2libc will be requested when the pull request is marked ready for review ret2libc is a code owner

@kazarmy kazarmy Awaiting requested review from kazarmy kazarmy will be requested when the pull request is marked ready for review kazarmy is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
ELF RzBin
Projects
None yet
Milestone
0.8.0
Development

Successfully merging this pull request may close these issues.

Autodetect asm.cpu whenever possible
4 participants
@valdaarhun @XVilka @DMaroo @JulyMoon87