Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wordpress 6.6 makes opening of subpages in Menu1 impossible #4

Open
extremecarver opened this issue Jul 19, 2024 · 23 comments
Open

Wordpress 6.6 makes opening of subpages in Menu1 impossible #4

extremecarver opened this issue Jul 19, 2024 · 23 comments

Comments

@extremecarver
Copy link
Collaborator

extremecarver commented Jul 19, 2024 •
edited
Loading

Updating to Wordpress 6.6 causes the submenu entries to not open anymore - so yu can only access top level pages from menu1 (and likely other menus).
See solution/workaround: #4 (comment)
@rivella50
Copy link
Owner

@extremecarver Do you get a corresponding error displayed which can lead us to a solution for that issue?

@extremecarver
Copy link
Collaborator Author

No nothing in console. Error not happening to your site(s)?

@rivella50
Copy link
Owner

I haven't updated yet to that WP version for the site i use Atahualpa.
Do you have time to investigate it? I could have a look at it next week earliest.

@extremecarver
Copy link
Collaborator Author

Ah okay, I have no clue how to investigate it as I see no errors. But I can just not update wordpress for a couple of weeks

@rivella50
Copy link
Owner

Perhaps the release notes for version 6.6 could give a hint...

@extremecarver
Copy link
Collaborator Author

Performance updates
WordPress 6.6 includes important updates like removing redundant WP_Theme_JSON calls, disabling autoload for large options, eliminating unnecessary polyfill dependencies, lazy loading post embeds, introducing the data-wp-on-async directive, and a 33% reduction in template loading time in the editor.

That's not telling much

@rivella50
Copy link
Owner

But we could have a look in the list of changed files (mainly menu related) what has changed there.

@extremecarver
Copy link
Collaborator Author

Above my knowledge of php. Seems only elemontor has a similar problem: https://wordpress.org/support/topic/wordpress-6-6-header-dropdown-menu-fail/

@rivella50
Copy link
Owner

rivella50 commented Jul 23, 2024 •
edited
Loading

I've just updated to Wordpress 6.6 on a local Docker installation for the homepage i support, and don't encounter the problem you mentioned, i.e. submenu items do show up and are clickable:

Screenshot 2024-07-23 at 15 22 47

@extremecarver
Copy link
Collaborator Author

extremecarver commented Jul 23, 2024 via email

@rivella50
Copy link
Owner

Docker logs say 8.0.28

@psychochicken80
Copy link

We have got the same problem with our page

@rivella50
Copy link
Owner

Which php version do both of you use? I will then try to install a wordpress image with that php version and see if i can reproduce the problem.

@extremecarver
Copy link
Collaborator Author

extremecarver commented Jul 25, 2024 via email

@rivella50
Copy link
Owner

I was able to run the homepage in another Docker container under php 8.3.9, and the (sub)menus work fine there too.
Could it be that you guys have special settings for Menu1 in Design->Atahualpa Theme Options which make submenus don't work correctly anymore?

@rivella50
Copy link
Owner

And could you also update to Wordpress version 6.6.1 and verify if the problem still exists?

@extremecarver
Copy link
Collaborator Author

extremecarver commented Jul 25, 2024 via email

@extremecarver
Copy link
Collaborator Author

ata-openmtbmaporg-20240725.txt

Here are my full theme options. But somehow I don't think they are the problem. I kinda defaulted everything and it was still the same (the delete bfa4 key option didn't work and I was too lazy to actually go into the databank after removing any custom code by hand for trying out).

@cbennett6008
Copy link

cbennett6008 commented Jul 26, 2024 •
edited
Loading

I have the same problem menu popups stopped working, and seems to have started around the same time with the 6.6 upgrade.
I was noticing a couple of jquery errors in the console, and I see this in the WP 6.6 information:
https://make.wordpress.org/core/2024/06/25/miscellaneous-developer-changes-in-wordpress-6-6/#jquery-ui-library-update
It also appears that I'm running an older version of the theme (.24), so I'll have to try upgrading that to see if that gets me anywhere.

@rivella50
Copy link
Owner

rivella50 commented Jul 26, 2024 •
edited
Loading

Ok, i've installed a brand new Wordpress 6.6.1, added a menu for Menu 1 with one sub menu item and applied Atahualpa 3.7.27. Apparently the menu didn't show the dropdown for the submenu item, only the main menu item.
Only when i applied that menu to Menu 1 under Position in Theme and saved it the submenu is shown again and clickable:
Screenshot 2024-07-26 at 11 15 17

Could you please ensure that your menu is also applied there?
But it's strange that this option seems to have such an impact. When i use one of the standard themes it doesn't matter if that option is selected or not, the submenu items are shown in both cases.

@extremecarver
Copy link
Collaborator Author

extremecarver commented Jul 26, 2024 •
edited
Loading

Thanks yeah that worked. Just makes it a bit complicated as I have to create that menu first... I used a menu for mobile menu so copying over worked. Basically it renders the Atahualpa Menu options obsolete. At least those about hiding pages or posts... From now on menu needs to be managed by wordpress not by Atahulapa options.

I used duplicate menu plugin to copy over my mobile menu which is a bit different. Sadly some translations weren't copied so some manual action needed on top. But good it works. Likely we should not close this bug as it's a bit unexpected, so people can read the solution more easily.

@rivella50
Copy link
Owner

rivella50 commented Jul 26, 2024 •
edited
Loading

Ok, great to hear.
Hopefully this also works for the other reporters of this problem.

If someone is interested: The relevant code can be found here (if no menu location has been chosen):

atahualpa/functions/bfa_header_config.php

Lines 31 to 71 in e83c9bf

else
{
ob_start();
echo '<div id="menu1">';
// Left, Right or Centered
if ( strpos($header_items,"%page-right") !== FALSE )
echo '<ul id="rmenu2" class="dropdown clearfix rMenu-hor rMenu-hRight rMenu">' . "\n";
elseif ( strpos($header_items,"%page-center") !== FALSE )
echo '<table cellpadding="0" cellspacing="0" style="margin: 0 auto"><tr><td align="center">
<ul id="rmenu2" class="clearfix rMenu-hor rMenu">' . "\n";
else
echo '<ul id="rmenu2" class="clearfix rMenu-hor rMenu">' . "\n";
// "Home" Link?
if ( $bfa_ata['home_page_menu_bar'] != '' )
{
echo '<li class="page_item';
if ( is_front_page() OR is_home() ) {
echo ' current_page_item';
}
echo '"><a href="' . $homeURL . '/" title="'; bloginfo('name'); echo '"><span>' .
$bfa_ata['home_page_menu_bar'] . '</span></a></li>' . "\n";
}
// Empty setting "levels" same as 0
if ( $bfa_ata['levels_page_menu_bar'] == '' )
$bfa_ata['levels_page_menu_bar'] = 0;
echo bfa_hor_pages($bfa_ata['sorting_page_menu_bar'], $bfa_ata['levels_page_menu_bar'],
$bfa_ata['titles_page_menu_bar'], $bfa_ata['exclude_page_menu_bar']);
// Close table if centered
if ( strpos($header_items,"%page-center") !== FALSE )
echo '</ul></td></tr></table></div>' . "\n";
else
echo '</ul></div>' . "\n";
$page_menu_bar = ob_get_contents();
ob_end_clean();
}

@MrPhilofaxy
Copy link

Thank you for the menu fix/work around. I've just applied it to about 4 different sites I look after!

All of them now have their drop down menus restored.

Many thanks
Steve in France

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@rivella50 @extremecarver @cbennett6008 @psychochicken80 @MrPhilofaxy