Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unison chords with diverging numbers of dots #3838

Open
rettinghaus opened this issue Oct 28, 2024 · 5 comments
Open

Unison chords with diverging numbers of dots #3838

rettinghaus opened this issue Oct 28, 2024 · 5 comments
Labels
enhancement low priority

Comments

@rettinghaus
Copy link
Contributor

Describe the problem
If a unison chord has diverging numbers of dots they are printed directly after the notepads instead after the chord.

To Reproduce
Steps to reproduce the behavior:

  1. Load the data attached
  2. Render page X
  3. See error

Expected behavior
Two lines of dots should be displayed after the chord, one for each notehead.

Input data

<?xml version="1.0" encoding="UTF-8"?>
<?xml-model href="https://music-encoding.org/schema/5.0/mei-all.rng" type="application/xml" schematypens="http://relaxng.org/ns/structure/1.0"?>
<?xml-model href="https://music-encoding.org/schema/5.0/mei-all.rng" type="application/xml" schematypens="http://purl.oclc.org/dsdl/schematron"?>
<mei xmlns="http://www.music-encoding.org/ns/mei" meiversion="5.0">
    <meiHead>
        <fileDesc>
            <titleStmt>
                <title>Chords with diverging number of dots</title>
            </titleStmt>
            <pubStmt>
                <respStmt>
                    <persName role="encoder">Klaus Rettinghaus</persName>
                </respStmt>
                <date isodate="2024-10-28">2024-10-28</date>
            </pubStmt>
            <seriesStmt>
                <title>Verovio test suite</title>
            </seriesStmt>
        </fileDesc>
    </meiHead>
    <music>
        <body>
            <mdiv>
                <score>
                    <scoreDef>
                        <staffGrp>
                            <staffDef n="1" lines="5">
                                <clef shape="G" line="2" visible="false" />
                            </staffDef>
                        </staffGrp>
                    </scoreDef>
                    <section>
                        <measure>
                            <staff n="1">
                                <layer n="1">
                                    <chord dur="2">
                                        <note dots="1" dur="2" oct="5" pname="e" pnum="64" />
                                        <note dots="2" dur="2" oct="5" pname="e" pnum="64" />
                                    </chord>
                                </layer>
                            </staff>
                        </measure>
                    </section>
                </score>
            </mdiv>
        </body>
    </music>
</mei>

Verovio information

  • develop
  • command-line

Environment information (as appropriate)

  • OS: MacOS

Screenshots
image
@rettinghaus rettinghaus added bug For issues describing crashes or unexpected behaviour low priority labels Oct 28, 2024
@lpugin
Copy link
Contributor

lpugin commented Oct 29, 2024

Out of curiosity, do you have a real life example for it?

@lpugin lpugin added enhancement and removed bug For issues describing crashes or unexpected behaviour labels Oct 29, 2024
@rettinghaus
Copy link
Contributor Author

No, not really. Stumbled upon this with an encoding found online, where the chord and every note has encoded dots.

@lpugin
Copy link
Contributor

lpugin commented Nov 1, 2024

FWIW, this is what MuseScore does
image
However, as far as I know, there is no way to have different numbers of dots.
I would suggest closing this issue, it can be reopen if a clear use-case comes up.

@rettinghaus
Copy link
Contributor Author

I made it low priority. 😉
When the dots only are present on the chord Verovio works fine. Not if they are also on the notes (there will be a warning though). Maybe we can at least handle these cases more gracefully?

@lpugin
Copy link
Contributor

lpugin commented Nov 1, 2024

I made it low priority. 😉

Yes, I saw that. I am suggesting to lower it further 😉

Verovio expectation is there should be no note in the chord with a longer duration (including dots) than the chord duration. So something like:

<chord dur="2">
   <note dots="1"/>
   <note dots="1"/>
</chord>

is problematic because the duration of the notes is longer than that of the chord.

This should be fine:

<chord dur="2">
   <note/>
   <note dur="4" dots="1"/>
</chord>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement low priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lpugin @rettinghaus