From 1595b01ba0c0c7f2165bc54e932bed7a51d5d364 Mon Sep 17 00:00:00 2001 From: TBCCC Date: Fri, 13 Dec 2024 16:30:08 +0800 Subject: [PATCH] chore: fix typos in func && doc && comment Signed-off-by: TBCCC --- docs/dev/src/design/relational-table.md | 2 +- src/batch/executors/src/executor/source.rs | 4 ++-- src/connector/src/connector_common/iceberg/storage_catalog.rs | 2 +- src/frontend/src/handler/util.rs | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/docs/dev/src/design/relational-table.md b/docs/dev/src/design/relational-table.md index f49907726e20e..dcff61313d7af 100644 --- a/docs/dev/src/design/relational-table.md +++ b/docs/dev/src/design/relational-table.md @@ -28,7 +28,7 @@ State Table provides the table operations by these APIs: `get_row`, `scan`, `ins ![Overview of Relational Table](../images/relational-table/relational-table-01.svg) ### Write Path -To write into KV state store, executors first perform operations on State Table, and these operations will be cached in Mem Table. Once a barrier flows through one executor, executor will flush the cached operations into state store. At this moment, State Table will covert these operations into kv pairs and write to state store with specific epoch. +To write into KV state store, executors first perform operations on State Table, and these operations will be cached in Mem Table. Once a barrier flows through one executor, executor will flush the cached operations into state store. At this moment, State Table will convert these operations into kv pairs and write to state store with specific epoch. For example, an executor performs `insert(a, b, c)` and `delete(d, e, f)` through the State Table APIs, Mem Table first caches these two operations in memory. After receiving new barrier, State Table converts these two operations into KV operations by row-based format, and writes these KV operations into state store (Hummock). diff --git a/src/batch/executors/src/executor/source.rs b/src/batch/executors/src/executor/source.rs index d5cb717df92a2..3bf7bea9bd82c 100644 --- a/src/batch/executors/src/executor/source.rs +++ b/src/batch/executors/src/executor/source.rs @@ -163,7 +163,7 @@ impl SourceExecutor { #[for_await] for chunk in stream { let chunk = chunk.map_err(BatchError::connector)?; - let data_chunk = covert_stream_chunk_to_batch_chunk(chunk)?; + let data_chunk = convert_stream_chunk_to_batch_chunk(chunk)?; if data_chunk.capacity() > 0 { yield data_chunk; } @@ -171,7 +171,7 @@ impl SourceExecutor { } } -fn covert_stream_chunk_to_batch_chunk(chunk: StreamChunk) -> Result { +fn convert_stream_chunk_to_batch_chunk(chunk: StreamChunk) -> Result { // chunk read from source must be compact assert!(chunk.data_chunk().is_compacted()); diff --git a/src/connector/src/connector_common/iceberg/storage_catalog.rs b/src/connector/src/connector_common/iceberg/storage_catalog.rs index 7a1b78444e94d..47acc810c8ca8 100644 --- a/src/connector/src/connector_common/iceberg/storage_catalog.rs +++ b/src/connector/src/connector_common/iceberg/storage_catalog.rs @@ -97,7 +97,7 @@ impl StorageCatalog { Error::new( ErrorKind::DataInvalid, format!( - "Fail to covert version_hint from utf8 to string: {}", + "Fail to convert version_hint from utf8 to string: {}", err.as_report() ), ) diff --git a/src/frontend/src/handler/util.rs b/src/frontend/src/handler/util.rs index e54fa7fb722c4..27e12a199f91a 100644 --- a/src/frontend/src/handler/util.rs +++ b/src/frontend/src/handler/util.rs @@ -268,7 +268,7 @@ pub fn convert_interval_to_u64_seconds(interval: &String) -> RwResult { let seconds = (Interval::from_str(interval) .map_err(|err| { ErrorCode::InternalError(format!( - "Covert interval to u64 error, please check format, error: {:?}", + "Convert interval to u64 error, please check format, error: {:?}", err.to_report_string() )) })?