Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support decimal for Iceberg source #19197

Open
fuyufjh opened this issue Oct 30, 2024 · 1 comment
Open

Support decimal for Iceberg source #19197

fuyufjh opened this issue Oct 30, 2024 · 1 comment
Assignees

Comments

@fuyufjh
Copy link
Member

fuyufjh commented Oct 30, 2024

Is your feature request related to a problem? Please describe.

Iceberg supports the standard fixed-point decimal-128, which supports up to 38 base-10 digits i.e. Decimal(38, S). While RisingWave supports float-point decimal-128, as a cost, it's up to 28 base-10 digits (29 in some cases).

Describe the solution you'd like

In real cases, although the column type is defines with Decimal(38, S), most values won’t have 38 digits.

That why I think we can round the number and record a warning somewhere in case that a row was really rounded.

Describe alternatives you've considered

No response

Additional context

No response

@chenzl25
Copy link
Contributor

After a discussion, we decided to let the iceberg source throw an error if it meets a decimal with precision that exceeds the precision risingwave can represent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants