-
Notifications
You must be signed in to change notification settings - Fork 665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The description of zext.w rd, rs is "Add unsigned word" #1321
Comments
IIRC, there was an effort to move things concerning pseudoinstructions out of the ISA manual and into the Assembly Manual, here: For example, in the case of
I'm still a proponent of having the Assembly Manual be the canonical reference for pseudoinstructions. I don't care strongly if they also appear in the ISA manual, as long as there aren't contradictions. |
Yes, the ISA spec will still mention certain stylized uses of instructions like this, especially if they might affect microarchitectural decisions. But the assembly manual should be the authority. |
I have no objection to the ASM manual being the master (there is not currently a list of pseudoinstructions in the ISA manual anyway, just scattered references), but it would be good to change the zext.w description in the ISA manual to "zero-extend halfword (pseudoinstruction for add.uw)". Of course it would also be good to update the ASM manual, as the text Nick cited is out of date I believe (the assembler presumably having a new expansion depending on the ISA string?). It might also be good to include a pointer in the ISA manual to the ASM manual (e.g. in the opcode listing, so someone doesn't wonder why certain opcodes don't exist). I don't know how cross-manual references are supposed to work however. |
You're obviously right, @eak. It took me a while to find the bug in the manual because it's the result of a cross-listing: the text "Add unsigned word" comes from a cross-link to |
Resolved by 7cbf1dc |
@aswaterman this has reverted and 'zext.w' is appearing in the documentation again. |
Fixed again in #1676 |
The description of zext.w rd, rs is "Add unsigned word" rather than "Zero-extend word" zext.w is a pseudoinstruction for add.uw, so this is a weird situation. It would be good if psuedoinstruction status was indicated in the table, and I still think the description should be Zero-extend word.
The text was updated successfully, but these errors were encountered: