Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect information in Vector Crypto Specification Release 1.0.0 #387

Open
michaelmaitland opened this issue Apr 24, 2024 · 4 comments
Open

Comments

@michaelmaitland
Copy link

I downloaded the PDF from the Vector Crypto Specification Release 1.0.0 and noticed it had the typo that had been fixed in ae384d5.

Is there the ability to fix this in the generated PDF? I understand there's been a big effort recently to merge all ratified extensions into riscv-isa-manual (where it is fixed), but I think it should still be fixed here, especially since that code change has been committed.

@nibrunieAtSi5
Copy link
Contributor

This repo has been archived and I am not sure we are going to generate a new spec from it. It might be clearer to remove the release version from here and points to the main repo. @wmat, @kdockser ?

@michaelmaitland
Copy link
Author

It might be clearer to remove the release version from here and points to the main repo. @wmat, @kdockser ?

That might be a good idea. This is the first result for a google search on risc-v vector crypto spec and there isn't much leading me to riscv-isa-manual once I click into the repo. Instead I found myself in the release pdf, believing this is the correct way to access the up to date spec.

@wmat
Copy link
Contributor

wmat commented Apr 25, 2024

I'm not exactly sure the best way to do this. I could add a link to riscv-isa-manual in the README. But are you asking me to remove the last 1.0.0 release?

@michaelmaitland
Copy link
Author

I could add a link to riscv-isa-manual in the README

Given that the 1.0.0 release is not the same as what is checked in the repo and that we don't plan to fix 1.0.0 release or put out a new one in this repo, I wouldn't be against removing the last release.

That being said, if the README said that the 1.0.0 release is not up to date with the code in the repo and to use riscv-isa-manual instead, that would have been enough to make me go read the riscv-isa-manual which does not have the error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants