Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify description of packw #156

Open
allenjbaum opened this issue Mar 16, 2022 · 0 comments
Open

Clarify description of packw #156

allenjbaum opened this issue Mar 16, 2022 · 0 comments

Comments

@allenjbaum
Copy link

The description text says:
This instruction packs the low 16 bits of rs1 and rs2 into the 32 least-significant bits of rd,..
while the Sail snippet effective does the reverse, i.e.
This instruction packs the low 16 bits of rs2 and rs1 into the 32 least-significant bits of rd...

This is especially confusing because zext.h uses the packw encoding, except rs2 is x0 -
it's just pseudocode for packw rd, rs1, x0.
That doesn't make sense if rs1 and rs2 are reversed in the description
So, non-normative text that explains that it's pseudocode also wouldn't hurt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant