Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest PDF theme fails #13

Closed
sameo opened this issue Apr 30, 2024 · 7 comments
Closed

Latest PDF theme fails #13

sameo opened this issue Apr 30, 2024 · 7 comments

Comments

@sameo
Copy link

sameo commented Apr 30, 2024

When using the latest docs-resources code (005cb0d), I get the following error:

❯ make build-no-container
Starting build...
make SKIP_DOCKER=true build-docs
make[1]: Entering directory '/home/samuel/devlp/specs/riscv/riscv-ap-tee-io'
asciidoctor-pdf --trace -a compress -a mathematical-format=svg -a revnumber=v0.0.0 -a revremark=Draft -a revdate=2024-04-30 -a pdf-fontsdir=docs-resources/fonts -a pdf-theme=docs-resources/themes/riscv-pdf.yml  -D build --failure-level=ERROR --require=asciidoctor-bibtex --require=asciidoctor-diagram --require=asciidoctor-mathematical src/riscv-cove-io.adoc
asciidoctor: ERROR: could not locate or load the built-in pdf theme `docs-resources/themes/riscv-pdf.yml' because of NoMethodError undefined method `each' for "646b74":String; reverting to default theme
make[1]: *** [Makefile:61: riscv-cove-io.pdf] Error 1
make[1]: Leaving directory '/home/samuel/devlp/specs/riscv/riscv-ap-tee-io'
make: *** [Makefile:83: build-no-container] Error 2
@sameo
Copy link
Author

sameo commented Apr 30, 2024

When using commit 37ec11d I do not see this error.

@wmat
Copy link
Collaborator

wmat commented Apr 30, 2024

Did you populate the submodule?

git submodule update --init

@sameo
Copy link
Author

sameo commented Apr 30, 2024

Did you populate the submodule?

git submodule update --init

Yes, I did. But when using the latest HEAD for that submodule, build fails.

The current ricv-ap-tee-io repo is at 37ec11d and build succeeds.

When trying to update it to 005cb0d, it fails. See riscv-non-isa/riscv-ap-tee-io#117

@wmat
Copy link
Collaborator

wmat commented Apr 30, 2024

Got it. There's a bug in the riscv-pdf.yml file. Working on it now.

@sameo
Copy link
Author

sameo commented May 2, 2024

I think this is fixed with #14 ?

@wmat
Copy link
Collaborator

wmat commented May 2, 2024

I still can't build the PDF locally. And oddly, if I add a new theme file into docs-resources/themes it builds. However, it creates a PDF with root permissions, so make clean breaks.

@wmat
Copy link
Collaborator

wmat commented May 23, 2024

@sameo closing this one as the riscv-ap-tee-io repo is building with the latest version of docs-resources. Also, make build-no-container works locally.

@wmat wmat closed this as completed May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants