Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dromajo SHA #169

Open
jeffnye-gh opened this issue May 9, 2024 · 2 comments
Open

dromajo SHA #169

jeffnye-gh opened this issue May 9, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@jeffnye-gh
Copy link
Collaborator

We are going to make changes to our fork of dromajo. I went to the Olympia read me on traces, to verify that a specific SHA for olympia/dromajo clone/build is specified rather than cloning HEAD.

I noticed the oly read-me page still references the previous patch mechanism.

Is this the mechanism olympia is using rather than using the Condor fork?I don't have a preference, it is not my call. It is about making sure the docs are aligned.

If you are using the patch mechanism then I don't need to check for a SHA in your docs.

If you are using the CPM fork, then the READ-ME needs an update to specify the SHA from Kathlene's commit.

This readme:
https://github.com/riscv-software-src/riscv-perf-model/blob/master/traces/README.md

The current dromajo HEAD has KM's changes merged:
ff13255a50bd1b5e7597f3bf2ceaf24b782e8b72

@klingaard
Copy link
Collaborator

Ugh, I actually forgot to finish the "port" of the olympia over to using the fork. I'll try to find some time to finish that up.

@jeffnye-gh
Copy link
Collaborator Author

no worries.

for completeness this is the url to our fork:
https://github.com/Condor-Performance-Modeling/dromajo

@klingaard klingaard self-assigned this Jun 5, 2024
@klingaard klingaard added the enhancement New feature or request label Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants