Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clang-format in place, but not applied #101

Open
ghost opened this issue Oct 16, 2023 · 0 comments
Open

clang-format in place, but not applied #101

ghost opened this issue Oct 16, 2023 · 0 comments

Comments

@ghost
Copy link

ghost commented Oct 16, 2023

Hi,

Thanks for uploading the .clang-format file. I tried applying the .clang-format to the files in this repo but it modifies all the files. For e.g.

diff --git a/core/Decode.cpp b/core/Decode.cpp
index 90e8f75..139d97e 100644
--- a/core/Decode.cpp
+++ b/core/Decode.cpp
@@ -1,6 +1,5 @@
 // <Decode.cpp> -*- C++ -*-

-
 #include <algorithm>

 #include "Decode.hpp"
@@ -12,20 +11,15 @@ namespace olympia
 {
     constexpr char Decode::name[];

-    Decode::Decode(sparta::TreeNode * node,
-                   const DecodeParameterSet * p) :
-        sparta::Unit(node),
-        fetch_queue_("FetchQueue", p->fetch_queue_size, node->getClock(), &unit_stat_set_),
-        num_to_decode_(p->num_to_decode)
+    Decode::Decode(sparta::TreeNode* node, const DecodeParameterSet* p) : sparta::Unit(node),
+                                                                          fetch_queue_("FetchQueue", p->fetch_queue_size, node->getClock(), &unit_stat_set_),
+                                                                          num_to_decode_(p->num_to_decode)

Can you please let me know if this is the expected behaviour? Is the .clang-format file meant for newly added files/code only? I used clang-format-15 to apply the format.

Originally posted by @RamVarad in #100

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants