-
Notifications
You must be signed in to change notification settings - Fork 839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a custom nginx.conf file #35
Comments
I like this, does it work for Windows?
…On Fri, Jul 3, 2020 at 3:43 PM Ivan Rivera ***@***.***> wrote:
First, thank you for this amazing tutorial. When I reached the Nginx
installation section, I thought that it wasn't optimal to move the contents
of my frontend into the nginx HTML directory and instead I decided to
create a custom nginx.conf file in my sa-frontend repo, so that way I can
launch the server with nginx -c nginx.conf. Here is what the server
definition of my conf file looks like:
server {
listen 80;
server_name localhost;
location / {
root /path/to/sa-frontend/build;
index index.html;
}
error_page 500 502 503 504 /50x.html;
location = /50x.html {
root html;
}
}
I think this is a cleaner solution so it might be worthwhile updating the
documentation with this.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#35>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACE3XE5WULB2762U7C5ACSTRZXOBTANCNFSM4OP2K6IQ>
.
|
Does it work on Windows? Good question! I'm not sure, I think it should, but I tested it on a Mac |
Mac is using linux underneath, which uses the same structure of storing
files, I am not sure how nginx would react with spaces which are rlly
frequent in Windows.
I currently do not have a Win computer, but if it could be tested there
it'd be great and I could update the article
Best
Rinor ✌️
…On Fri, Jul 3, 2020 at 3:50 PM Ivan Rivera ***@***.***> wrote:
Does it work on Windows? Good question! I'm not sure, I think it should,
but I tested it on a Mac
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#35 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACE3XE2DNY5D3Z2EQE4T6U3RZXOYTANCNFSM4OP2K6IQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
First, thank you for this amazing tutorial. When I reached the Nginx installation section, I thought that it wasn't optimal to move the contents of my frontend into the nginx HTML directory and instead I decided to create a custom nginx.conf file in my sa-frontend repo, so that way I can launch the server with
nginx -c nginx.conf
. Here is what theserver
definition of myconf
file looks like:I think this is a cleaner solution for running the app locally, however, if we run the app on Docker, then we should probably stick with the original approach.
The text was updated successfully, but these errors were encountered: