Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can not read text response #106

Open
tylerlong opened this issue Mar 12, 2019 · 3 comments
Open

Can not read text response #106

tylerlong opened this issue Mar 12, 2019 · 3 comments

Comments

@tylerlong
Copy link
Contributor

if (!this._isJson() && !this._isMultipart()) throw new Error('Response is not text');

if (!this._isJson() && !this._isMultipart()) throw new Error('Response is not text');

But HTTP PUT /restapi/v1.0/glip/groups/{groupId}/posts/{postId}/text returns text which will cause exception.

@kirill-konshin
Copy link
Contributor

Huh, API now returns plain text? Do you want to address this in 3.x or you're OK to update to 4.x where this should not be an issue?

@tylerlong
Copy link
Contributor Author

tylerlong commented Mar 13, 2019

@kirill-konshin

Yes there is one and only one endpoint returning text.

Is 4.x in production now? How can I get started? I prefer an upgrade guide.

Many thanks!

@kirill-konshin
Copy link
Contributor

kirill-konshin commented Mar 13, 2019

It is in beta. But it’s public so you can install it from NPM.

I suppose we can fix the issue by adding additional check for plain text but still I suggest to switch to 4.x.

Also take a look at rollup branch - it has the migration guide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants