You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The trace distance is given by $T(\rho, \sigma) = (1/2)|\rho-\sigma|_1$ where $|\cdot|_1$ is the Schatten 1-norm (as correctly indicated in the docs).
In the implementation, however, a call is made to numpy.linalg.norm(rho - sigma, 1), which uses the matrix norm induced by the vector 1-norm (i.e., the maximum absolute column sum).
Instead the implementation should call numpy.linalg.norm(rho - sigma, 'nuc') to compute the nuclear norm (synonymous with the Schatten 1-norm).
The text was updated successfully, but these errors were encountered:
marcusps
added a commit
to marcusps/forest-benchmarking
that referenced
this issue
Oct 31, 2024
The trace distance is given by$T(\rho, \sigma) = (1/2)|\rho-\sigma|_1$ where $|\cdot|_1$ is the Schatten 1-norm (as correctly indicated in the docs).
In the implementation, however, a call is made to
numpy.linalg.norm(rho - sigma, 1)
, which uses the matrix norm induced by the vector 1-norm (i.e., the maximum absolute column sum).Instead the implementation should call
numpy.linalg.norm(rho - sigma, 'nuc')
to compute the nuclear norm (synonymous with the Schatten 1-norm).The text was updated successfully, but these errors were encountered: