Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

post data structure refactor issues #126

Open
4 of 5 tasks
joshcombes opened this issue May 15, 2019 · 0 comments
Open
4 of 5 tasks

post data structure refactor issues #126

joshcombes opened this issue May 15, 2019 · 0 comments

Comments

@joshcombes
Copy link
Contributor

joshcombes commented May 15, 2019

  • standardize argument order e.g. my_fun(qpu, qvm, benchmarker, parameters) rather than any old order.
  • standardize argument names and variable names e.g. n_shots vs num_shots; qubit vs qcid vs qb; angles vs phases; excited state or |1>
  • Fix existing style violation and add style linting (flake8) to the CI/CD pipeline
  • Add type hinting everywhere in the source code, remove from docstrings
  • Standardize return types e.g. aquire_data should return standard error not variances, estimate_X should return standard error not variances
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant