You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently Karapace requests fail if "references" is set, even if empty: "Unrecognized field: references". Aiven-Open/karapace#195
In order to support Karapace in srclient I suggest adding an arg to the CreateSchemaRegistryClient method that allows to override the default behaviour if needed. The only change would be to add omitempty on the References field in the structs and looking at the arg to decide if the default empty value for References should be set.
It comes down to omitempty treating empty and nil the same way. It would have to be a different struct sent to the registry in order to make absolutely no changes to the data that goes over the wire. If I manage to pack this nicely somehow and make no changes to the requests I'll reopen the PR.
Currently Karapace requests fail if "references" is set, even if empty: "Unrecognized field: references".
Aiven-Open/karapace#195
In order to support Karapace in srclient I suggest adding an arg to the CreateSchemaRegistryClient method that allows to override the default behaviour if needed. The only change would be to add
omitempty
on the References field in the structs and looking at the arg to decide if the default empty value for References should be set.Here is my closed PR with code for reference
#68
The text was updated successfully, but these errors were encountered: