Additional tests

Author: hendrikebbers

remoting/rico-remoting-common/src/main/java/dev/rico/internal/remoting/RemotingConstants.java

@@ -33,6 +33,6 @@ public interface RemotingConstants {
 
     String INTERNAL_ATTRIBUTES_BEAN_NAME = "@@@ HIGHLANDER_BEAN @@@";
 
-    String REMOTING_DATE_FORMAT_PATTERN = "yyyy-MM-dd'T'HH:mm:ss.SSS'Z'";
+    String REMOTING_DATE_FORMAT_PATTERN = "yyyy-MM-dd'T'HH:mm:ss.SSSXXX";
 
 }

remoting/rico-remoting-common/src/test/java/dev/rico/internal/remoting/converters/LocalDateConverterTest.java

@@ -21,6 +21,7 @@
 import org.testng.Assert;
 import org.testng.annotations.Test;
 
+import java.text.ParseException;
 import java.time.LocalDate;
 import java.time.LocalDateTime;
 import java.time.LocalTime;
@@ -66,6 +67,7 @@ public void testSameTimeZone() throws ValueConverterException {
 
         //when
         final Object rawObject = converter.convertToRemoting(time);
+        System.out.println(rawObject);
         final Object reConverted = converter.convertFromRemoting(rawObject);
 
         //then
@@ -107,4 +109,32 @@ public void testDifferentTimeZone() throws ValueConverterException {
         }
     }
 
+    @Test
+    public void testRawSameTimeZone() throws ValueConverterException, ParseException {
+        final TimeZone defaultZone = TimeZone.getDefault();
+        try {
+
+            //given
+            final LocalDateConverterFactory localDateFactory = new LocalDateConverterFactory();
+            final Converter localDateConverter = localDateFactory.getConverterForType(LocalDate.class);
+            final ZonedDateTimeConverterFactory zonedDateTimeFactory = new ZonedDateTimeConverterFactory();
+            final Converter zonedDateTimeConverter = zonedDateTimeFactory.getConverterForType(LocalDate.class);
+            final String rawObject = "2019-01-30T11:25:07.341+03:00";
+            final ZonedDateTime zonedDateTime = (ZonedDateTime) zonedDateTimeConverter.convertFromRemoting(rawObject);
+            final LocalDate fromZonedTime = LocalDate.from(zonedDateTime);
+
+            //when
+            final Object reconvertedLocalDate = localDateConverter.convertFromRemoting(rawObject);
+
+            //then
+            Assert.assertNotNull(reconvertedLocalDate);
+            Assert.assertTrue(LocalDate.class.isAssignableFrom(reconvertedLocalDate.getClass()));
+            final LocalDate reconvertedTime = (LocalDate) reconvertedLocalDate;
+            Assert.assertEquals(reconvertedTime, fromZonedTime);
+
+        } finally {
+            TimeZone.setDefault(defaultZone);
+        }
+    }
+
 }

remoting/rico-remoting-common/src/test/java/dev/rico/internal/remoting/converters/LocalDateTimeConverterTest.java

@@ -76,7 +76,7 @@ public void testSameTimeZone() throws ValueConverterException {
         Assert.assertEquals(reconvertedTime, time);
     }
 
-    @Test(enabled = false)
+    @Test
     public void testDifferentTimeZone() throws ValueConverterException {
         final TimeZone defaultZone = TimeZone.getDefault();
         try {

remoting/rico-remoting-common/src/test/java/dev/rico/internal/remoting/converters/ZonedDateTimeConverterTest.java

@@ -21,10 +21,13 @@
 import org.testng.Assert;
 import org.testng.annotations.Test;
 
+import java.text.ParseException;
+import java.time.LocalDate;
 import java.time.LocalDateTime;
 import java.time.ZoneId;
 import java.time.ZonedDateTime;
 import java.util.Objects;
+import java.util.TimeZone;
 
 public class ZonedDateTimeConverterTest {
 
@@ -71,7 +74,7 @@ public void testSameTimeZone() throws ValueConverterException {
         Assert.assertEquals(reconvertedTime, time);
     }
 
-    @Test(enabled = false)
+    @Test
     public void testDifferentTimeZone() throws ValueConverterException {
         //given
         final ZonedDateTimeConverterFactory factory = new ZonedDateTimeConverterFactory();
@@ -86,6 +89,7 @@ public void testDifferentTimeZone() throws ValueConverterException {
 
         //when
         final Object rawObject = converter.convertToRemoting(time);
+        System.out.println(rawObject);
         final Object reConverted = converter.convertFromRemoting(rawObject);
 
         //then
@@ -96,4 +100,28 @@ public void testDifferentTimeZone() throws ValueConverterException {
         Assert.assertEquals(reconvertedTime, time);
     }
 
+    @Test
+    public void testRawSameTimeZone() throws ValueConverterException, ParseException {
+        final TimeZone defaultZone = TimeZone.getDefault();
+        try {
+
+            //given
+            final ZonedDateTimeConverterFactory zonedDateTimeFactory = new ZonedDateTimeConverterFactory();
+            final Converter zonedDateTimeConverter = zonedDateTimeFactory.getConverterForType(LocalDate.class);
+            final String rawObject = "2019-01-30T11:25:07.341+08:00";
+
+            //when
+            final Object reconverted = zonedDateTimeConverter.convertFromRemoting(rawObject);
+
+            //then
+            Assert.assertNotNull(reconverted);
+            Assert.assertTrue(ZonedDateTime.class.isAssignableFrom(reconverted.getClass()));
+            final ZonedDateTime reconvertedTime = (ZonedDateTime) reconverted;
+            Assert.assertEquals(ZoneId.of("Australia/Sydney"), reconvertedTime.getZone());
+
+        } finally {
+            TimeZone.setDefault(defaultZone);
+        }
+    }
+
 }