Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

errors when enabled together with other extension #52

Open
DaWolfi opened this issue Mar 29, 2021 · 4 comments
Open

errors when enabled together with other extension #52

DaWolfi opened this issue Mar 29, 2021 · 4 comments

Comments

@DaWolfi
Copy link

DaWolfi commented Mar 29, 2021

Hi, thanks for your very useful extension!
But I noticed a strange behaviour when enabled together with the extension "Here Unicode Mate", which displays the Unicode number of the char behind the cursor in the status line.
A piece of code from the file "lodash-sortkeys.js" from your extension is displayed instead of the number, at least when a json file is opened in the editor. And when the command, that ist triggered by a clicking the number, displays a list of different encodings for the char, some entries are also containing pieces of your code:
image
image

@richie5um
Copy link
Owner

How strange; I get the same. I'll take a look at the code for that extension and try and work out why.

@aolszowka
Copy link

aolszowka commented Mar 6, 2023

Thank you for this extension, it is very useful, however I wanted to add additional information to this bug report:

This appears to break the ARMView extension (bencoleman.armview) as well (See benc-uk/armview-vscode#54). I was able to identify this by performing an Extension Bisect and ruled this in as the culprit.

The behavior is the same (adding // Shortcut helper to move item to end of array) as seen in the screenshot.

For now, I have disabled this extension.

You can reproduce the issue following the steps in the linked bug report.

@richie5um
Copy link
Owner

Thanks. I've been incredibly busy with my work for a while. Hopefully I'll get some time to look at this. It was non-obvious last time I had a chance to look.

@aolszowka
Copy link

Thanks. I've been incredibly busy with my work for a while. Hopefully I'll get some time to look at this. It was non-obvious last time I had a chance to look.

No worries, open source is a labor of love, and I appreciate your extension. If people want it fixed the code is there for them to provide a patch ;)

If you need any help repro'ing or testing a fix I'm willing to volunteer, that was a tricky one to track down!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants