Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False-Positive duplicate matrix config #523

Open
DNKpp opened this issue Mar 17, 2025 · 0 comments
Open

False-Positive duplicate matrix config #523

DNKpp opened this issue Mar 17, 2025 · 0 comments

Comments

@DNKpp
Copy link

DNKpp commented Mar 17, 2025

Hello,
I'm using actionlint online checker from time to time. It's very helpful to me, thank you very much.

But recently I got the feeling, that there may be a bug in the duplicate checker.

- prefix: "Windows 2022"
  os: "windows-2022"
  compiler_name: "msvc"
  compiler_version: "v143"
  cmake_generator: "Visual Studio 17 2022"

- prefix: "Windows 2022"
  suffix: "/Gv"
  os: "windows-2022"
  compiler_name: "msvc"
  compiler_version: "v143"
  cmake_generator: "Visual Studio 17 2022"
  default_call_convention: "vectorcall"

It claims, that these two matrix entries would be a duplicate of each other, which they are not (at least from my knowledge).

duplicate value {"cmake_generator": "Visual Studio 17 2022", "compiler_name": "msvc", "compiler_version": "v143", "default_call_convention": "vectorcall", "os": "windows-2022", "prefix": "Windows 2022", "suffix": "/Gv"} is found in matrix "config". the same value is at line:182,col:13matrix

When I change the order, the error is gone, which leads me to the conclusion, that the duplicate check does only check whether any previous entry is a subset of the new element (not actually the same).

Here is a link to the specific file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant