Adding dbus interface for loading locale keyboards #6093

adamkankovsky · 2025-01-14T09:29:35Z

No description provided.

pep8speaks · 2025-01-14T11:24:42Z

Hello @adamkankovsky! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file pyanaconda/modules/common/structures/keyboard_layout.py:

Line 49:32: E231 missing whitespace after ':'
Line 58:26: E231 missing whitespace after ':'

In the file pyanaconda/modules/localization/localization.py:

Line 57:1: E731 do not assign a lambda expression, use a def
Line 58:1: E731 do not assign a lambda expression, use a def

Comment last updated at 2025-01-23 13:22:16 UTC

pyanaconda/localization.py

jkonecny12 · 2025-01-14T17:21:26Z

Also we shouldn't forget about localization of the layouts
https://github.com/rhinstaller/anaconda/blob/main/pyanaconda%2Fui%2Fgui%2Fxkl_wrapper.py#L32-L33

We can resolve on the UI side or provide a separate API for that. Something like get_localized. Not sure what is better approach

jkonecny12

Thanks a lot for this improvement! I would like to know what do you think about the notes below before setting ACK.

pyanaconda/modules/localization/localization.py

pyanaconda/localization.py

pyanaconda/ui/gui/xkl_wrapper.py

jkonecny12

Looks good to me.

I just wonder how we are going to resolve the localization? Will that be DBus API or a UI code?

adamkankovsky · 2025-01-16T09:30:38Z

/kickstart-test --testtype smoke

jkonecny12 · 2025-01-27T12:23:15Z

pyanaconda/modules/localization/localization.py

+Xkb_ = lambda x: gettext.translation("xkeyboard-config", fallback=True).gettext(x)
+iso_ = lambda x: gettext.translation("iso_639", fallback=True).gettext(x)


I guess these needs to be used somewhere?

Yes I know, this is just a change to debug the WebUI where the localization is removed

jkonecny12

Looks great to me now. Thanks!

jkonecny12 · 2025-01-28T15:55:46Z

/kickstart-test --testtype smoke

jkonecny12 · 2025-01-28T15:55:59Z

/kickstart-test --testtype keyboard

Adding dbus interface for loading locale keyboards Remove duplicate function and migrate to localization one

adamkankovsky · 2025-01-29T10:52:46Z

/kickstart-test --testtype smoke

rvykydal · 2025-01-29T12:38:06Z

/build-image --boot.iso

github-actions · 2025-01-29T12:49:36Z

Images built based on commit 468c9ad:

boot.iso: success

Download the images from the bottom of the job status page.

adamkankovsky · 2025-01-29T14:23:36Z

/kickstart-test reboot-initial-setup-tui

adamkankovsky temporarily deployed to gh-cockpituous January 14, 2025 09:29 — with GitHub Actions Inactive

github-actions bot added the f42 Fedora 42 label Jan 14, 2025

adamkankovsky force-pushed the localization-keyboard branch from 7d20779 to 7e0b385 Compare January 14, 2025 09:30

adamkankovsky temporarily deployed to gh-cockpituous January 14, 2025 09:30 — with GitHub Actions Inactive

adamkankovsky requested a review from KKoukiou January 14, 2025 09:32

adamkankovsky force-pushed the localization-keyboard branch from 7e0b385 to 879695c Compare January 14, 2025 11:24

adamkankovsky temporarily deployed to gh-cockpituous January 14, 2025 11:24 — with GitHub Actions Inactive

adamkankovsky force-pushed the localization-keyboard branch from 879695c to 84b7321 Compare January 14, 2025 12:33

adamkankovsky temporarily deployed to gh-cockpituous January 14, 2025 12:33 — with GitHub Actions Inactive

adamkankovsky force-pushed the localization-keyboard branch from 84b7321 to b14b523 Compare January 14, 2025 12:37

adamkankovsky temporarily deployed to gh-cockpituous January 14, 2025 12:37 — with GitHub Actions Inactive

adamkankovsky requested a review from jkonecny12 January 14, 2025 14:20

jkonecny12 requested changes Jan 14, 2025

View reviewed changes

pyanaconda/localization.py Outdated Show resolved Hide resolved

adamkankovsky force-pushed the localization-keyboard branch from b14b523 to 5847497 Compare January 15, 2025 12:49

adamkankovsky temporarily deployed to gh-cockpituous January 15, 2025 12:49 — with GitHub Actions Inactive

adamkankovsky requested a review from jkonecny12 January 15, 2025 13:19

jkonecny12 requested changes Jan 15, 2025

View reviewed changes

pyanaconda/modules/localization/localization.py Outdated Show resolved Hide resolved

pyanaconda/localization.py Outdated Show resolved Hide resolved

pyanaconda/ui/gui/xkl_wrapper.py Show resolved Hide resolved

adamkankovsky force-pushed the localization-keyboard branch from 5847497 to f722550 Compare January 15, 2025 14:06

adamkankovsky temporarily deployed to gh-cockpituous January 15, 2025 14:06 — with GitHub Actions Inactive

adamkankovsky requested a review from jkonecny12 January 15, 2025 14:07

adamkankovsky force-pushed the localization-keyboard branch from f722550 to d5bf365 Compare January 15, 2025 15:15

adamkankovsky temporarily deployed to gh-cockpituous January 15, 2025 15:16 — with GitHub Actions Inactive

jkonecny12 approved these changes Jan 15, 2025

View reviewed changes

adamkankovsky force-pushed the localization-keyboard branch from d5bf365 to efd8ae2 Compare January 16, 2025 13:30

adamkankovsky temporarily deployed to gh-cockpituous January 16, 2025 13:30 — with GitHub Actions Inactive

adamkankovsky force-pushed the localization-keyboard branch from efd8ae2 to 1e474e6 Compare January 16, 2025 13:42

adamkankovsky temporarily deployed to gh-cockpituous January 16, 2025 13:42 — with GitHub Actions Inactive

jkonecny12 reviewed Jan 27, 2025

View reviewed changes

adamkankovsky force-pushed the localization-keyboard branch from 6fa12ad to 82f4add Compare January 28, 2025 09:04

adamkankovsky temporarily deployed to gh-cockpituous January 28, 2025 09:04 — with GitHub Actions Inactive

adamkankovsky force-pushed the localization-keyboard branch from 82f4add to 0931690 Compare January 28, 2025 09:23

adamkankovsky temporarily deployed to gh-cockpituous January 28, 2025 09:23 — with GitHub Actions Inactive

adamkankovsky force-pushed the localization-keyboard branch from 0931690 to fb322bc Compare January 28, 2025 09:49

adamkankovsky temporarily deployed to gh-cockpituous January 28, 2025 09:50 — with GitHub Actions Inactive

adamkankovsky force-pushed the localization-keyboard branch from fb322bc to 416a225 Compare January 28, 2025 12:06

adamkankovsky temporarily deployed to gh-cockpituous January 28, 2025 12:06 — with GitHub Actions Inactive

adamkankovsky force-pushed the localization-keyboard branch from 416a225 to b6c76d3 Compare January 28, 2025 12:10

adamkankovsky temporarily deployed to gh-cockpituous January 28, 2025 12:10 — with GitHub Actions Inactive

adamkankovsky force-pushed the localization-keyboard branch from b6c76d3 to 2636605 Compare January 28, 2025 14:24

adamkankovsky temporarily deployed to gh-cockpituous January 28, 2025 14:24 — with GitHub Actions Inactive

adamkankovsky force-pushed the localization-keyboard branch from 2636605 to 02cfc02 Compare January 28, 2025 15:24

adamkankovsky temporarily deployed to gh-cockpituous January 28, 2025 15:24 — with GitHub Actions Inactive

adamkankovsky force-pushed the localization-keyboard branch from 02cfc02 to 7e7e182 Compare January 28, 2025 15:28

adamkankovsky temporarily deployed to gh-cockpituous January 28, 2025 15:28 — with GitHub Actions Inactive

adamkankovsky force-pushed the localization-keyboard branch from 7e7e182 to 49d125b Compare January 28, 2025 15:47

adamkankovsky temporarily deployed to gh-cockpituous January 28, 2025 15:47 — with GitHub Actions Inactive

jkonecny12 approved these changes Jan 28, 2025

View reviewed changes

adamkankovsky added 2 commits January 29, 2025 11:52

Add test for GetLocaleKeyboardLayouts

458f7fb

Creating a dbus interface to get local keyboard layouts

468c9ad

Adding dbus interface for loading locale keyboards Remove duplicate function and migrate to localization one

adamkankovsky force-pushed the localization-keyboard branch from 49d125b to 468c9ad Compare January 29, 2025 10:52

adamkankovsky had a problem deploying to gh-cockpituous January 29, 2025 10:52 — with GitHub Actions Failure

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding dbus interface for loading locale keyboards #6093

Adding dbus interface for loading locale keyboards #6093

adamkankovsky commented Jan 14, 2025

pep8speaks commented Jan 14, 2025 •

edited

Loading

jkonecny12 commented Jan 14, 2025 •

edited

Loading

jkonecny12 left a comment

jkonecny12 left a comment

adamkankovsky commented Jan 16, 2025

jkonecny12 Jan 27, 2025

adamkankovsky Jan 27, 2025

jkonecny12 left a comment

jkonecny12 commented Jan 28, 2025

jkonecny12 commented Jan 28, 2025

adamkankovsky commented Jan 29, 2025

rvykydal commented Jan 29, 2025

github-actions bot commented Jan 29, 2025

adamkankovsky commented Jan 29, 2025

		Xkb_ = lambda x: gettext.translation("xkeyboard-config", fallback=True).gettext(x)
		iso_ = lambda x: gettext.translation("iso_639", fallback=True).gettext(x)

Adding dbus interface for loading locale keyboards #6093

Are you sure you want to change the base?

Adding dbus interface for loading locale keyboards #6093

Conversation

adamkankovsky commented Jan 14, 2025

pep8speaks commented Jan 14, 2025 • edited Loading

Comment last updated at 2025-01-23 13:22:16 UTC

jkonecny12 commented Jan 14, 2025 • edited Loading

jkonecny12 left a comment

Choose a reason for hiding this comment

jkonecny12 left a comment

Choose a reason for hiding this comment

adamkankovsky commented Jan 16, 2025

jkonecny12 Jan 27, 2025

Choose a reason for hiding this comment

adamkankovsky Jan 27, 2025

Choose a reason for hiding this comment

jkonecny12 left a comment

Choose a reason for hiding this comment

jkonecny12 commented Jan 28, 2025

jkonecny12 commented Jan 28, 2025

adamkankovsky commented Jan 29, 2025

rvykydal commented Jan 29, 2025

github-actions bot commented Jan 29, 2025

adamkankovsky commented Jan 29, 2025

pep8speaks commented Jan 14, 2025 •

edited

Loading

jkonecny12 commented Jan 14, 2025 •

edited

Loading