Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable plugin usage via --jira-enabled=true #93

Open
liiight opened this issue Jul 13, 2018 · 2 comments
Open

Enable plugin usage via --jira-enabled=true #93

liiight opened this issue Jul 13, 2018 · 2 comments

Comments

@liiight
Copy link
Contributor

liiight commented Jul 13, 2018

I'd like to have the option wether to use the plugin or not pass as an envvar in my CI. Currently this is possible either via manipulating the command arts via a bash script or using the PYTEST_ADDOPTS envvar. Both of these aren't nice.

I propose adding a --jira-enabled=true option, that will accompany the other existing flags as to not break compatibility.

If you like this I can put out a PR for this change.

WDYT?

@lukas-bednar
Copy link
Member

I am worried about --jira flag, the presence or absence of this flag says whether to enable or disable this plugin.
This --jira-enable flags seems to be duplicate to me ... or I am overlooking something ?

@liiight
Copy link
Contributor Author

liiight commented Jul 16, 2018

hmm, using pytest's PYTEST_ADDOPTS seems nicer than I though:

$ PYTEST_ADDOPTS="--jira"
$ pytest

I was thinking using an explicit flag would be nicer though:

$ JIRA_ENABLED="true"
$ pytest --jira-enabled=$JIRA_ENABLED

But I guess it's a minor/not an issue...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants