Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caravan loading 'Accept' button doesn't work when mechanoid is added #50

Open
smallnamespace opened this issue Aug 6, 2020 · 4 comments

Comments

@smallnamespace
Copy link

smallnamespace commented Aug 6, 2020

Rimworld version 1.1.2654
What the Hack version 0.5.0.0

Even with a fueled portable charging station that says >0 days fuel remaining, ticking the check mark next to a mechanoid results in the 'Accept' button in the create caravan screen to no-op, so the caravan can't be created.

Removing the mechanoid lets the caravan begin loading. No visible errors or log messages.

@rheirman
Copy link
Owner

rheirman commented Aug 6, 2020

Did you also test this with just vanilla, what the hack, and Giddy up to rule out if it's a conflict with another mod?

@smallnamespace
Copy link
Author

Yes, I just confirmed with the bare modlist and the issue is still present.

In dev mode I see this stack trace:

Exception filling window for RimWorld.Dialog_FormCaravan: System.NullReferenceException: Object reference not set to an instance of an object at WhatTheHack.Harmony.Dialog_FormCaravan_DoBottomButtons.AddWarnings (RimWorld.Dialog_FormCaravan instance, System.Collections.Generic.List`1[System.String]& warnings) [0x0012f] in <e946ea286bfc48ac9bf712e475d7b9a5>:0 at (wrapper dynamic-method) RimWorld.Dialog_FormCaravan.RimWorld.Dialog_FormCaravan.DoBottomButtons_Patch0(RimWorld.Dialog_FormCaravan,UnityEngine.Rect) at RimWorld.Dialog_FormCaravan.DoWindowContents (UnityEngine.Rect inRect) [0x001f4] in <b9022531d79047b2b6baad3f7d519f01>:0 at Verse.Window.InnerWindowOnGUI (System.Int32 x) [0x00165] in <b9022531d79047b2b6baad3f7d519f01>:0 Verse.Log:Error(String, Boolean) Verse.Window:InnerWindowOnGUI(Int32) UnityEngine.GUI:CallWindowDelegate(WindowFunction, Int32, Int32, GUISkin, Int32, Single, Single, GUIStyle)

@rheirman
Copy link
Owner

I'll look into it when updating the mod to 1.2.

By the way, did you confirm it with the same version of Rimworld you reporting before? I'm asking because 1.2 just released.

@smallnamespace
Copy link
Author

Yup, I'd downgraded to 1.1 to double-check.

Btw, this is the first large add-on I've tried over vanilla and it adds a lot of depth to mid-late game. Thanks for continuing to maintain this alongside working on your own game!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants