Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mixing of i686 and i386 archs #8

Open
andrlos opened this issue May 19, 2021 · 4 comments
Open

mixing of i686 and i386 archs #8

andrlos opened this issue May 19, 2021 · 4 comments

Comments

@andrlos
Copy link
Collaborator

andrlos commented May 19, 2021

It seems that a common practice in rpms is to mix i386 things into i686 rpms. This messes up with our tests, as the tests expect i686 folder but for example in java-1.8.0-openjdk-devel-1.8.0.292.b10-3.fc33.i686.rpm there is /usr/lib/jvm/java-1.8.0-openjdk-1.8.0.292.b10-3.fc33.i386/bin/ bin folder..
this results in rather large amount of tests failing as those are unable to locate relevant binaries in expected folders.. question is whether its something that should be fixed in the rpms or should be expected in the test.

@judovana
Copy link
Collaborator

the i686 and i386 should be synonyms from view of JSF.
Actually from view of jsf i686=i586=i486=i386==i286=x86-x86_32=86_32=86=intel32b
I recomend to have a better comapring function considering above equation, or to have some sanitize call before each operation unifying the 32b namings

@judovana
Copy link
Collaborator

judovana commented May 19, 2021

maybe on el8 and up and fedoras on jdk11 and up, we can igore that some 32b java does exists at all...

@andrlos
Copy link
Collaborator Author

andrlos commented May 19, 2021

ok, will be done :-)

@andrlos
Copy link
Collaborator Author

andrlos commented May 19, 2021

this affects particularly these tests:
BinariesTest#_perform_all_checks
BinariesTest#all_jre_in_sdk_check
BinariesTest#check_java_cgi
BinariesTest#check_subdirectory_slaves
ManpageTests#man_page_test
ManpageTests#manpage_file_check
ManpageTests#manpage_links_check
PostinstallScriptTest#_check_post_in_script

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants