Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interested in PRs from things in BitsX.jl ? #2

Open
jlapeyre opened this issue Oct 5, 2022 · 0 comments
Open

Interested in PRs from things in BitsX.jl ? #2

jlapeyre opened this issue Oct 5, 2022 · 0 comments

Comments

@jlapeyre
Copy link

jlapeyre commented Oct 5, 2022

I pushed a repo BitsX.jl that depends on Bits.jl and extends it. A good bit of the things in BitsX might be moved to Bits.jl.

Just one example: [these lines] (https://github.com/jlapeyre/BitsX.jl/blob/7ee71eb77558924e7d557e3c0d0b66318d2425bb/src/BitsX.jl#L278-L279) (and _Bits === Bits)

Base.:(<)(v1::_Bits.AbstractBitVector1, v2::_Bits.AbstractBitVector1) = v1.x < v2.x
Base.isless(v1::_Bits.AbstractBitVector1, v2::_Bits.AbstractBitVector1) = v1 < v2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jlapeyre