-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New AnnotationHubDispatchClassList? #6
Comments
Or should we go directly for |
I suppose you refer to this issue. But we can't necessarily anticipate what the developer is sharing their data for. And your suggestion requires two inputs (and mzML and the sample annotation), and I'm not sure this fits the bill here, as the hub infrastructure is mean to share (individual) files. To fit your suggestion, we should share two files, one that could be loaded as a |
Hm, agree - and needing two separate files would not be ideal. So, we might go for |
Yes, I think that's the basic idea - I share a file and it get loaded automatically as the best object. If, as a developer, I want a Spectra object containing data from multiple files, it would be my job to create that files beforehand. |
yes. makes sense. |
Or simply join the |
When creating an ExperimentHub package, it is possible to define dispatch classes, so that some file types can be loaded automatically and returned as predefined objects. See
AnnotationHub::DispatchClassList()
:For
MsDataHub
, we want"FilePath"
, as we want to get the file path and then load the data ourselves. We could also directly get the desired object, for example aSpectra
object created bySpectra()
if the file is anmzML
.Should we ask to add
Spectra
(and possibly others such asPSM
formzid
files) to the default dispatch classes?Ping @jorainer
The text was updated successfully, but these errors were encountered: