adding english-monarchs-and-marriages (enmoma) dataset

[frankiethull]

creating the english-monarchs-and-marriages branch, aka enmoma for short. testing the pull request method with tidytuesday team on this old issue 480.

one thing to note, I did not use ttsave()!, I'm not sure if that function exists or if I'm missing a step, please review saving.R script.

[jonthegeek]

Please try to run the source() line in saving.R, and let me know if that doesn't work. It SHOULD give you the ttsave() function, which (in addition to saving the dataset) creates the data dictionary and runs some (minimal for now but more to come) checks.

We clearly need to make this instruction clearer in any case!

[jonthegeek]

I can't give this a full review right now, so I'm sending this single comment. If you don't have a chance to update things right away, no worries. I'll try to dig into the rest of this submission sometime tomorrow.

Thank you so much for testing this process! You're the first person to learn the process purely from the instructions, and there are clearly some things for us to clarify!

[jonthegeek]

Just a couple tweaks needed. I could just implement themselves, but I wanted to check with you about the credit (eg, if you'd like to include an affiliation or anything along those lines).

Thank you so much for being our Guinea pig!

[lgibson7]

Yay! Our first (correct me if I'm wrong @jonthegeek) externally curated Tidy Tuesday data set. Thank you so much @frankiethull. I truly appreciate your help with this.

[jonthegeek]

Yay! Our first (correct me if I'm wrong @jonthegeek) externally curated Tidy Tuesday data set. Thank you so much @frankiethull. I truly appreciate your help with this.

Not first ever, but first using the new, formal system. The one or two we've had in the past ended up needing a lot of manual edits to fit the format, since we didn't have any guidance on what to do. So this is still a very "yay!" moment!

[frankiethull]

"yay!" moment confirmed over here!! Glad to be your guinea pig and that credit is perfectly fine with me.

I use the vertical bar "|" often so this is a helpful note for next time.

I had shared a handful of datasets back in 2022, which looks like they will all be closed issues now (woohoo!). But with this new process, I'll be on the lookout for other interesting datasets. I also saw you all did a rebranding as DSLC, congratulations, I have been out of the loop!

Additionally saw this, "We hope to provide instructions for other programming languages soon", I could always be a tester for Julia and Python too, let me know when and where 😤

[jonthegeek]

/assign enmoma 2024-08-20

[jonthegeek]

I have to commit one fix that I didn't catch (but it became obvious after the script to assign this to a week). Thanks again! Your contribution will appear as next week's dataset!