Pass default value weights = null to SvgDrawer.draw()
#175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r.draw()` Resolves reymond-group#171. Although the `weights` parameter was added to `SvgDrawer.draw()` in f3693b3, the method call in `Drawer.draw()` wasn't updated correspondingly. `Drawer.draw()` could be amended to also take a `weights` argument, which it would pass to `SvgDrawer.draw()`, but this might break existing code even more and would require an update of the documentation of the README.
✅ Deploy Preview for smilesdrawer-doc canceled.
|
|
It should also fix #161 |
CrazydduGi
approved these changes
Jan 31, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #171. Although the
weightsparameter was added toSvgDrawer.draw()in f3693b3, the method call inDrawer.draw()wasn't updated correspondingly.Drawer.draw()could be amended to also take aweightsargument, which it would pass toSvgDrawer.draw(), but this might break existing code even more and would require an update of the documentation of the README.Example to reproduce:
Before the proposed change, this gives an error (
TypeError: this.svgWrapper is null). With the proposed change, the error is resolved and the structure is displayed correctly.