Skip to content

Commit a916b55

Browse files
author
mikivee
committed
train on new upgrades
1 parent 0d3e3d0 commit a916b55

File tree

2 files changed

+3
-7
lines changed

2 files changed

+3
-7
lines changed

scripts/build_feature_store.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1403,10 +1403,7 @@ def transform_weather_features() -> DataFrame:
14031403

14041404
# DBTITLE 1,Write out building metadata feature store
14051405
table_name = "ml.surrogate_model.building_features"
1406-
# TODO: remove this drop statement before retraining-- this is just a temp (yes hacky i know back off) solution to not break dohyo dowstream
1407-
df = building_metadata_applicable_upgrades_with_weather_file_city_index.drop(
1408-
"heat_pump_sizing_methodology"
1409-
)
1406+
df = building_metadata_applicable_upgrades_with_weather_file_city_index
14101407
if spark.catalog.tableExists(table_name):
14111408
fe.write_table(name=table_name, df=df, mode="merge")
14121409
else:

src/datagen.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@ class DataGenerator(tf.keras.utils.Sequence):
4141
- fe (databricks.feature_engineering.client.FeatureEngineeringClient: client for interacting with the
4242
Databricks Feature Engineering in Unity Catalog
4343
44-
TODO: modify this be more flexible to use this at inference time only (e.g, don't load various feature tables into mem)
4544
"""
4645

4746
# init FeatureEngineering client
@@ -70,6 +69,7 @@ class DataGenerator(tf.keras.utils.Sequence):
7069
# heating
7170
"heating_fuel",
7271
"heating_appliance_type",
72+
"heat_pump_sizing_methodology",
7373
"has_ducted_heating",
7474
"heating_efficiency_nominal_percentage",
7575
"heating_setpoint_degrees_f",
@@ -155,8 +155,7 @@ class DataGenerator(tf.keras.utils.Sequence):
155155
"propane": ["propane__total"],
156156
}
157157

158-
# TODO: add 13.01 and 11.05 before training new model
159-
supported_upgrade_ids = [0.0, 1.0, 3.0, 4.0, 6.0, 9.0]
158+
supported_upgrade_ids = [0.0, 1.0, 3.0, 4.0, 6.0, 9.0, 13.01, 11.05]
160159

161160
def __init__(
162161
self,

0 commit comments

Comments
 (0)